Add LWIP IPv6 zone index in chip::Inet::IPAddress #36387
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
|
andy31415
reviewed
Nov 6, 2024
|
PR #36387: Size comparison from da2b767 to f86577f Increases above 0.2%:
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@db-shelly please sign the CLA |
andy31415
approved these changes
Nov 7, 2024
|
It seems that we cannot set an assigment, we should modify all constructors instead.... |
|
PR #36387: Size comparison from da2b767 to 55e5740 Increases above 0.2%:
Full report (30 builds for linux, nrfconnect, qpg, stm32, telink, tizen)
|
| @@ -201,6 +201,9 @@ class DLL_EXPORT IPAddress | |||
| * address in network byte order. | |||
| */ | |||
| uint32_t Addr[4]; | |||
| #if CHIP_SYSTEM_CONFIG_USE_LWIP && LWIP_IPV6_SCOPES | |||
| uint8_t Zone = IP6_NO_ZONE; | |||
There was a problem hiding this comment.
Does LwIP use zones for non-link-local bits?
Because for link-local, PeerAddress is supposed to have an interface ID already, which is what the zone bits are, no? Is that not being handled correctly in our LwIP integration? Because if that's what's going on, the right fix is to fix it there, not to add things to IPAddress that are also duplicated-but-unused-it's-a-trap in PeerAddress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using LWIP without any patches and with LWIP_IPV6_SCOPES=1, outbound connections cannot be routed to the correct interface, because zone index is missing in chip::Inet::IPAddress.
This is a simple fix to keep the ip6_addr_t zone in IPAddress if needed.