[darwin-framework-tool] Add an optional -use-mtr-device argument to read-by-id and write-by-id commands #36243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using an MTRDevice instead of a MTRBaseDevice
…ding attributes via an MTRDevice
…ting attributes via an MTRDevice
|
Review changes with SemanticDiff. |
|
PR #36243: Size comparison from f1457a2 to 4b48f5b Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 25, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ead-by-id and write-by-id commands (project-chip#36243) * [darwin-framework-tool][use-mtr-device] Add an option to send command using an MTRDevice instead of a MTRBaseDevice * [darwin-framework-tool][use-mtr-device] Add an implementation for reading attributes via an MTRDevice * [darwin-framework-tool][use-mtr-device] Add an implementation for writing attributes via an MTRDevice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds an optional argument to the
read-by-idandwrite-by-idcommands, allowing the use of anMTRDeviceinstead of anMTRBaseDevice. The two classes have different behaviors, so this option is useful for testing and debugging by allowing commands to be sent through either class.