[Matter.framework] Move various #define to src/platform/Darwin/CHIPPl… #36178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36178: Size comparison from 605e3f5 to d5ca4ab Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
MatterFramework_NoCHIPAppProjectConfig
branch
from
d5ca4ab to
c96b62d
Compare
|
PR #36178: Size comparison from 6f0a70c to c96b62d Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
MatterFramework_NoCHIPAppProjectConfig
branch
from
c96b62d to
f24edd3
Compare
|
PR #36178: Size comparison from 4269ff5 to f24edd3 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…atformConfig.h by defautl instead of relying on CHIPProjectAppConfig.h
vivien-apple
force-pushed
the
MatterFramework_NoCHIPAppProjectConfig
branch
from
f24edd3 to
baee8a3
Compare
|
PR #36178: Size comparison from 5eb3cc0 to baee8a3 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 23, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…atformConfig.h by defautl instead of relying on CHIPProjectAppConfig.h (project-chip#36178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atformConfig.h by defautl instead of relying on CHIPProjectAppConfig.h
Problem
Some build flags in
config/ios/CHIPProjectConfig.hare now obsolete. Additionally, a few others could potentially be moved tosrc/platform/Darwin/CHIPPlatformConfig.hfor better organization.