Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add temperature control cluster impl for laundry washer #36105

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
+645 −28
Open

Add temperature control cluster impl for laundry washer #36105

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
896050e
add temperature control cluster impl for laundry washer
stingchang Oct 16, 2024
0ec3f4d
add washer mode reader writer
stingchang Oct 17, 2024
176695b
Merge branch 'master' into chef-laundry-washer
stingchang Oct 17, 2024
95c436c
Merge branch 'master' into chef-laundry-washer
stingchang Oct 18, 2024
bd06efb
remove extra import
stingchang Oct 18, 2024
cef24bf
fix style
stingchang Oct 18, 2024
63d2048
Restyled by clang-format
restyled-commits Oct 18, 2024
08aa6f1
Merge branch 'master' into chef-laundry-washer
stingchang Oct 21, 2024
431e9c4
update temperature level
stingchang Oct 21, 2024
d7ad77b
Merge branch 'master' into chef-laundry-washer
stingchang Oct 23, 2024
49854f4
string span; OnOff DF feature;
stingchang Oct 23, 2024
b799c98
Restyled by clang-format
restyled-commits Oct 23, 2024
a89a4aa
copyright year
stingchang Oct 23, 2024
dd8267f
Merge branch 'master' into chef-laundry-washer
stingchang Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update temperature level
  • Loading branch information
@stingchang
stingchang committed Oct 21, 2024
commit 431e9c40fb5d082f6b28975a91b5a2c7ec6e3a91
4 changes: 2 additions & 2 deletions examples/chef/common/clusters/temperature-control/static-supported-temperature-levels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ using chip::Protocols::InteractionModel::Status;

app::Clusters::TemperatureControl::AppSupportedTemperatureLevelsDelegate sAppSupportedTemperatureLevelsDelegate;

CharSpan AppSupportedTemperatureLevelsDelegate::temperatureLevelOptions[] = { CharSpan("Hot", 3), CharSpan("Warm", 4),
CharSpan("Freezing", 8) };
CharSpan AppSupportedTemperatureLevelsDelegate::temperatureLevelOptions[] = { CharSpan("Low", 3), CharSpan("Medium", 6),
stingchang marked this conversation as resolved.
Show resolved Hide resolved
CharSpan("High", 4) };
const AppSupportedTemperatureLevelsDelegate::EndpointPair AppSupportedTemperatureLevelsDelegate::supportedOptionsByEndpoints
[MATTER_DM_TEMPERATURE_CONTROL_CLUSTER_SERVER_ENDPOINT_COUNT] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static_assert that MATTER_DM_TEMPERATURE_CONTROL_CLUSTER_SERVER_ENDPOINT_COUNT is exactly 1? You seem to assume that on initializing and also during various operations. The code seems generally quite coupled as a result.

EndpointPair(1, AppSupportedTemperatureLevelsDelegate::temperatureLevelOptions, 3) // Options for Endpoint 1
stingchang marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading