Moving more stuff out of the MTRDevice #36090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36090: Size comparison from 579b1b1 to 151a7ac Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -309,4 +309,41 @@ - (void)downloadLogOfType:(MTRDiagnosticLogType)type | |||
| // Not Supported via XPC | |||
| // - (oneway void)downloadLogOfType:(MTRDiagnosticLogType)type nodeID:(NSNumber *)nodeID timeout:(NSTimeInterval)timeout completion:(void (^)(NSURL * _Nullable url, NSError * _Nullable error))completion; | |||
|
|
|||
| #pragma mark - Storage Overrides | |||
|
|
|||
| - (NSDictionary<MTRClusterPath *, MTRDeviceClusterData *> *)_clusterDataToPersistSnapshot | |||
There was a problem hiding this comment.
If the goal is to not have persistence at all in MTRDevice_XPC, then we should just rip it out of MTRDevice, not do this, I think....
| @@ -1646,11 +1646,6 @@ - (void)_scheduleClusterDataPersistence | |||
| } | |||
| [_mostRecentReportTimes addObject:[NSDate now]]; | |||
|
|
|||
| { | |||
| std::lock_guard lock(_descriptionLock); | |||
| _mostRecentReportTimeForDescription = [_mostRecentReportTimes lastObject]; | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
I just copied and pasted the base implementation into concrete, please fix :)
|
I think we should do #36132 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTRDevice is still using some basic C++ stuff here, we should be not doing this in MTRDevice_XPC, I did a quick and simple hack here. @bzbarsky-apple