Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing feature map bit #35961

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add missing feature map bit #35961

merged 1 commit into from
Oct 8, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

Light-Switch Data Model didn't have the correct feature map bits for what the apps would generate.
PR updates the ZAP configurations with the correct FeatureMap value.

Issue was found as part of the SVE testing for the Switch Cluster
PR #35915 is already merged on master.

Testing

Certification tests

@mkardous-silabs
Add missing feature map bit (project-chip#35915)
5a07068 
* Add missing feature map bit

* Generation
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@mkardous-silabs mkardous-silabs changed the title Add missing feature map bit (#35915) Add missing feature map bit Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

PR #35961: Size comparison from cec1887 to 5a07068

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section cec1887 5a07068 change % change
bl602 lighting-app bl602 FLASH 1280598 1280598 0 0.0
RAM 95808 95808 0 0.0
bl602+mfd FLASH 1308646 1308646 0 0.0
RAM 95464 95464 0 0.0
bl602+rpc FLASH 1335266 1335266 0 0.0
RAM 103784 103784 0 0.0
bl702 lighting-app bl702 FLASH 945020 945020 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957474 957474 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051178 1051178 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658152 658152 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824948 824948 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961956 961956 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974718 974718 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829332 829332 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814656 814656 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761220 761220 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745456 745456 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616962 616962 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657058 657058 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678301 678301 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698153 698153 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698153 698153 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655089 655089 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614645 614645 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634273 634273 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634273 634273 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633949 633949 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653665 653665 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653665 653665 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609245 609245 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629105 629105 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629105 629105 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933844 933844 0 0.0
RAM 135876 135876 0 0.0
lock-app BRD2605a FLASH 740248 740248 0 0.0
RAM 230240 230240 0 0.0
BRD4338a FLASH 740896 740896 0 0.0
RAM 230272 230272 0 0.0
window-app BRD4187C FLASH 1017256 1017248 -8 -0.0
RAM 127804 127804 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1538452 1538452 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548894 1548894 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2780057 2780057 0 0.0
RAM 129488 129488 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6084086 6084086 0 0.0
RAM 512416 512416 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5417336 5417336 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4750778 4750778 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12673616 12673616 0 0.0
RAM 563410 563410 0 0.0
chip-tool-ipv6only arm64 unknown 20736 20736 0 0.0
FLASH 11307328 11307328 0 0.0
RAM 613728 613728 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11019585 11019585 0 0.0
RAM 563066 563066 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4574006 4574006 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5691393 5691393 0 0.0
RAM 228456 228456 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4800372 4800372 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4429764 4429764 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4568578 4568578 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3110141 3110141 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4318368 4318368 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6028277 6028277 0 0.0
RAM 585952 585952 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10870893 10870893 0 0.0
RAM 651888 651888 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914236 914236 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885036 885036 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847652 847652 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581992 581992 0 0.0
RAM 70784 70784 0 0.0
k32w1+release FLASH 596696 596696 0 0.0
RAM 63008 63008 0 0.0
mcxw71+release FLASH 596456 596456 0 0.0
RAM 63008 63008 0 0.0
light k32w0+release FLASH 618580 618580 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682680 682680 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682696 682696 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705032 705032 0 0.0
RAM 67148 67148 0 0.0
mcxw71+release FLASH 705056 705056 0 0.0
RAM 67148 67148 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646124 1646124 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552180 1552180 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467652 1467652 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464724 1464724 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660336 660336 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618348 618348 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481632 481632 0 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620754 620754 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687952 687952 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780944 780944 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680850 680850 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620518 620518 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708460 708460 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625456 625456 0 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811216 811216 0 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656424 656424 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696828 696828 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634152 634152 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611342 611342 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627668 627668 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653474 653474 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 638074 638074 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524212 524212 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725900 1725900 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10456 10456 0 0.0
FLASH 17544434 17544434 0 0.0
RAM 7642364 7642364 0 0.0

@mergify mergify bot merged commit 1dadbe4 into project-chip:master Oct 8, 2024
69 checks passed
@mkardous-silabs mkardous-silabs deleted the cherry-pick/switch_feature_map branch October 8, 2024 14:14
@mkardous-silabs mkardous-silabs restored the cherry-pick/switch_feature_map branch October 8, 2024 14:15
@mergify Mergify
Copy link

mergify bot commented Oct 8, 2024

⚠️ The sha of the head commit of this PR conflicts with #35966. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @arkq @yunhanw-google