-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a test-only method from base MTRDeviceController. #35944
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:move-test-only-to-concrete
Oct 8, 2024
Merged
Remove a test-only method from base MTRDeviceController. #35944
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:move-test-only-to-concrete
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
bzbarsky-apple
force-pushed
the
move-test-only-to-concrete
branch
from
October 7, 2024 17:05
c818245
to
d27a4e0
Compare
PR #35944: Size comparison from 1c2ad2e to d27a4e0 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jtung-apple
approved these changes
Oct 7, 2024
bzbarsky-apple
force-pushed
the
move-test-only-to-concrete
branch
from
October 7, 2024 20:47
d27a4e0
to
fa67aa1
Compare
PR #35944: Size comparison from 55e2a3f to fa67aa1 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This is only used with concrete controllers from tests, and is already implemented by MTRDeviceController_Concrete. Also removes a test-only class method from MTRDeviceController_Concrete that MTRDeviceController already implements (and has to keep implementing, since the tests use it on MTRDeviceController itself, not an instance).
bzbarsky-apple
force-pushed
the
move-test-only-to-concrete
branch
from
October 8, 2024 01:57
fa67aa1
to
6ed5cc3
Compare
bzbarsky-apple
changed the title
Remove some test-only methods from base MTRDeviceController.
Remove a test-only method from base MTRDeviceController.
Oct 8, 2024
PR #35944: Size comparison from 9fc8386 to 6ed5cc3 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only used with concrete controllers from tests, and is already implemented by MTRDeviceController_Concrete.
Also removes a test-only class method from MTRDeviceController_Concrete that MTRDeviceController already implements (and has to keep implementing, since the tests use it on MTRDeviceController itself, not an instance).