Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute-table logs to not log strings as %p. #35941

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix attribute-table logs to not log strings as %p. #35941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/app/util/attribute-table.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ Status emAfWriteAttribute(const ConcreteAttributePath & path, const EmberAfWrite
// if we dont support that attribute
if (metadata == nullptr)
{
ChipLogProgress(Zcl, "%p ep %x clus " ChipLogFormatMEI " attr " ChipLogFormatMEI " not supported",
"WRITE ERR: ", path.mEndpointId, ChipLogValueMEI(path.mClusterId), ChipLogValueMEI(path.mAttributeId));
ChipLogProgress(Zcl, "WRITE ERR: ep %x clus " ChipLogFormatMEI " attr " ChipLogFormatMEI " not supported", path.mEndpointId,
ChipLogValueMEI(path.mClusterId), ChipLogValueMEI(path.mAttributeId));
return status;
}

Expand All @@ -352,13 +352,13 @@ Status emAfWriteAttribute(const ConcreteAttributePath & path, const EmberAfWrite
{
if (input.dataType != metadata->attributeType)
{
ChipLogProgress(Zcl, "%p invalid data type", "WRITE ERR: ");
ChipLogProgress(Zcl, "WRITE ERR: invalid data type");
return Status::InvalidDataType;
}

if (metadata->IsReadOnly())
{
ChipLogProgress(Zcl, "%p attr not writable", "WRITE ERR: ");
ChipLogProgress(Zcl, "WRITE ERR: attr not writable");
return Status::UnsupportedWrite;
}
}
Expand Down
Loading