Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing: Create leading directories if they don't exist #35668

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Tracing: Create leading directories if they don't exist #35668

merged 1 commit into from
Sep 19, 2024

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Sep 19, 2024

Problem

When running python3 ./src/python_testing/execute_python_tests.py --env-file test-env.yaml --search-directory src/python_testing locally without creating out/trace_data everything hangs without any meaningful output. The problem is that the output from test scripts is silenced and in case of missing out/trace_data the tracing fails which hangs everything.

Changes

  • Create trace file leading directories if they do not exist

Testing

Tested locally that now tests work without pre-creating out/trace_data directory.

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 19, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 4 files.

Filename Status
❔ src/tracing/perfetto/file_output.cpp Unsupported file format
❔ src/tracing/json/json_tracing.cpp Unsupported file format
❔ src/controller/python/chip/tracing/TracingSetup.cpp Unsupported file format
✔️ src/controller/python/chip/tracing/__init__.py Analyzed

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

PR #35668: Size comparison from 884d9fa to a86d0f2

Increases above 0.2%:

platform target config section 884d9fa a86d0f2 change % change
linux all-clusters-app debug unknown 5456 5528 72 1.3
all-clusters-minimal-app debug unknown 5352 5424 72 1.3
bridge-app debug unknown 5336 5408 72 1.3
chip-tool debug unknown 5888 5960 72 1.2
fabric-admin debug unknown 5720 5792 72 1.3
fabric-bridge-app debug unknown 4568 4640 72 1.6
lighting-app debug+rpc+ui unknown 5984 6056 72 1.2
lock-app debug unknown 5272 5344 72 1.4
ota-provider-app debug unknown 4648 4720 72 1.5
ota-requestor-app debug unknown 4584 4656 72 1.6
thermostat-no-ble arm64 unknown 9392 9416 24 0.3
tv-app debug unknown 5552 5624 72 1.3
tizen chip-tool-ubsan arm unknown 10276 10312 36 0.4
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 884d9fa a86d0f2 change % change
bl602 lighting-app bl602 FLASH 1279984 1279984 0 0.0
RAM 95848 95848 0 0.0
bl602+mfd FLASH 1294106 1294106 0 0.0
RAM 95992 95992 0 0.0
bl602+rpc FLASH 1319196 1319196 0 0.0
RAM 104272 104272 0 0.0
bl702 lighting-app bl702 FLASH 944100 944100 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946500 946500 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039420 1039420 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646296 646296 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 894372 894372 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960760 960760 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963382 963382 0 0.0
RAM 16964 16964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677613 677613 0 0.0
RAM 78516 78516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697465 697465 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697465 697465 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654393 654393 0 0.0
RAM 73584 73584 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613653 613653 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633281 633281 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633281 633281 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632909 632909 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652617 652617 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652617 652617 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608317 608317 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628177 628177 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628177 628177 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 932700 932700 0 0.0
RAM 135080 135080 0 0.0
lock-app BRD2605a FLASH 740504 740496 -8 -0.0
RAM 231220 231220 0 0.0
BRD4338a FLASH 741152 741144 -8 -0.0
RAM 231252 231252 0 0.0
window-app BRD4187C FLASH 1016048 1016040 -8 -0.0
RAM 127004 127004 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1537360 1537360 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1547798 1547798 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2764181 2764181 0 0.0
RAM 129424 129424 0 0.0
all-clusters-app debug unknown 5456 5528 72 1.3
FLASH 6066320 6067670 1350 0.0
RAM 507360 507360 0 0.0
all-clusters-minimal-app debug unknown 5352 5424 72 1.3
FLASH 5399652 5401002 1350 0.0
RAM 241136 241136 0 0.0
bridge-app debug unknown 5336 5408 72 1.3
FLASH 4733208 4734558 1350 0.0
RAM 218304 218304 0 0.0
chip-tool debug unknown 5888 5960 72 1.2
FLASH 12544540 12545836 1296 0.0
RAM 555058 555058 0 0.0
chip-tool-ipv6only arm64 unknown 20400 20424 24 0.1
FLASH 11242996 11253488 10492 0.1
RAM 605144 605288 144 0.0
fabric-admin debug unknown 5720 5792 72 1.3
FLASH 10902985 10904335 1350 0.0
RAM 554234 554234 0 0.0
fabric-bridge-app debug unknown 4568 4640 72 1.6
FLASH 4555868 4557218 1350 0.0
RAM 204888 204888 0 0.0
lighting-app debug+rpc+ui unknown 5984 6056 72 1.2
FLASH 5669441 5670801 1360 0.0
RAM 228560 228560 0 0.0
lock-app debug unknown 5272 5344 72 1.4
FLASH 4782412 4783762 1350 0.0
RAM 204376 204376 0 0.0
ota-provider-app debug unknown 4648 4720 72 1.5
FLASH 4415596 4416946 1350 0.0
RAM 198112 198112 0 0.0
ota-requestor-app debug unknown 4584 4656 72 1.6
FLASH 4554344 4555694 1350 0.0
RAM 202680 202680 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3094877 3094877 0 0.0
RAM 159184 159184 0 0.0
thermostat-no-ble arm64 unknown 9392 9416 24 0.3
FLASH 4326820 4337360 10540 0.2
RAM 242664 242808 144 0.1
tv-app debug unknown 5552 5624 72 1.3
FLASH 6011541 6012901 1360 0.0
RAM 580896 580896 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10739405 10739405 0 0.0
RAM 642976 642976 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913292 913292 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884992 884992 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846804 846804 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581760 581760 0 0.0
RAM 70776 70776 0 0.0
k32w1+release FLASH 594216 594216 0 0.0
RAM 62952 62952 0 0.0
mcxw71+release FLASH 593976 593976 0 0.0
RAM 62952 62952 0 0.0
light k32w0+release FLASH 617620 617620 0 0.0
RAM 70248 70248 0 0.0
k32w1+release FLASH 680856 680856 0 0.0
RAM 48584 48584 0 0.0
mcxw71+release FLASH 680872 680872 0 0.0
RAM 48584 48584 0 0.0
lock k32w1+release FLASH 702840 702840 0 0.0
RAM 67084 67084 0 0.0
mcxw71+release FLASH 702864 702864 0 0.0
RAM 67084 67084 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645108 1645108 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551108 1551108 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1466924 1466924 0 0.0
RAM 200696 200696 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463540 1463540 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 659368 659368 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 617252 617252 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 480904 480904 0 0.0
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621936 621936 0 0.0
RAM 50988 50988 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687178 687178 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780122 780122 0 0.0
RAM 110780 110780 0 0.0
bridge-app tlsr9258a FLASH 680958 680958 0 0.0
RAM 91644 91644 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621700 621700 0 0.0
RAM 50940 50940 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707608 707608 0 0.0
RAM 74280 74280 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624856 624856 0 0.0
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810264 810264 0 0.0
RAM 99448 99448 0 0.0
lock-app-dfu tlsr9528a FLASH 655454 655454 0 0.0
RAM 67000 67000 0 0.0
ota-requestor-app tlsr9258a FLASH 696934 696934 0 0.0
RAM 91236 91236 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633290 633290 0 0.0
RAM 55816 55816 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610480 610480 0 0.0
RAM 53060 53060 0 0.0
shell tlsr9518adk80d FLASH 467170 467170 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628666 628666 0 0.0
RAM 52660 52660 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652616 652616 0 0.0
RAM 56608 56608 0 0.0
thermostat tlsr9518adk80d FLASH 637210 637210 0 0.0
RAM 53452 53452 0 0.0
window-covering tlsr9118bdk40d FLASH 523386 523386 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4876 4876 0 0.0
FLASH 1721832 1721832 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10276 10312 36 0.4
FLASH 17345290 17348194 2904 0.0
RAM 7556512 7558368 1856 0.0

@pullapprove pullapprove bot requested a review from jtov-sfy September 19, 2024 14:28
@mergify mergify bot merged commit afb1a33 into project-chip:master Sep 19, 2024
68 checks passed
@arkq arkq deleted the tracing-up branch September 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@andy31415 andy31415 Awaiting requested review from andy31415

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@saurabhst saurabhst Awaiting requested review from saurabhst

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkq @andy31415 @saurabhst