[Test] Creating CADMIN 1.19 python3 test module #35611
Open
+177
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test module created following steps in PR: CHIP-Specifications/chip-test-plans#4669
|
Review changes with SemanticDiff. Analyzed 2 of 3 files.
|
j-ororke
changed the title
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #35611: Size comparison from 010ad94 to 76142a6 Full report (26 builds for efr32, esp32, nxp, telink)
|
- Resolving linting issues
- Removed yaml test as we have created python test module in its place
|
PR #35611: Size comparison from 010ad94 to 4c04d29 Full report (3 builds for nxp)
|
- Removed debugging print statements as no longer needed in test code
|
PR #35611: Size comparison from 010ad94 to 9ef5882 Full report (26 builds for efr32, esp32, nxp, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
cecille
reviewed
Oct 22, 2024
src/python_testing/TC_CADMIN_1_19.py
Outdated
|
|
||
|
|
||
| class TC_CADMIN_1_19(MatterBaseTest): | ||
| async def OpenCommissioningWindow(self) -> CommissioningParameters: |
There was a problem hiding this comment.
can you use the openCommissionignWindow function in matter_testing instead of re-implementing?
There was a problem hiding this comment.
I have updated the code to remove the OpenCommissioningWindow and CommissionAttempt local class functions to using the MatterBaseTest version of those here now.
Also, added the timeout variable to allow dynamic setting of now instead of statically set.
src/python_testing/TC_CADMIN_1_19.py
Outdated
| setupPinCode = params.setupPinCode | ||
|
|
||
| self.step("5b") | ||
| fids_ca_dir['thca' + str(fid)] = self.certificate_authority_manager.NewCertificateAuthority() |
There was a problem hiding this comment.
why are you using strings as keys rather than just numbers if they're separate dicts?
There was a problem hiding this comment.
So, I had been using it to make the names a bit easier possibly to read the names, but since not needed I have changed those to using just the range number now for the dictionary key names.
src/python_testing/TC_CADMIN_1_19.py
Outdated
| self.step("5b") | ||
| fids_ca_dir['thca' + str(fid)] = self.certificate_authority_manager.NewCertificateAuthority() | ||
| fids_fa_dir['thfa' + str(fid)] = fids_ca_dir['thca' + str(fid)].NewFabricAdmin(vendorId=0xFFF1, fabricId=fid) | ||
| fids['th' + str(fid)] = fids_fa_dir['thfa' + str(fid)].NewController(nodeId=fid, useTestCommissioner=True) |
There was a problem hiding this comment.
You don't need to use the test commissioner here.
There was a problem hiding this comment.
Thank you, this has been removed from the test script
cecille
removed
the
matter-1.4-te2-script-change
Co-authored-by: C Freeman <cecille@google.com>
github-actions
bot
added
the
matter-1.4-te2-script-change
Co-authored-by: C Freeman <cecille@google.com>
j-ororke
removed
the
matter-1.4-te2-script-change
|
PR #35611: Size comparison from 0b93b0d to eb3a03f Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updated CI Arguments - Updated dependency location for matter_testing_support - Removed local OpenCommissioningWindow function, updated to using MatterBaseTest version - Removed local CommissioningAttempt function, moved to using function call directly in test - Removed initialization of TH2 controller as not needed - Removed additional dictionary names and delimited it down to just using numbers instead. - Updated matter_testing support script to include setting timeout value dynamically in openCommissioningWindow function
github-actions
bot
added
the
matter-1.4-te2-script-change
Resolving Linting errors
|
PR #35611: Size comparison from 0b93b0d to a9f2650 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating python3 TC CADMIN 1.19 test module: