[TC WHM 2.1] - Implement test steps 5-9 #35596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 14% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #35596: Size comparison from 9de3c6b to 7fcd47c Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Sep 16, 2024
|
PR #35596: Size comparison from 9de3c6b to 0f52dbf Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jamesharrow
reviewed
Sep 17, 2024
| @@ -76,18 +77,37 @@ def pics_TC_WHM_2_1(self) -> list[str]: | |||
| @async_test_body | |||
| async def test_TC_WHM_2_1(self): | |||
|
|
|||
| asserts.assert_true('PIXIT.WHM.MODE_CHANGE_OK' in self.matter_test_config.global_test_params, | |||
There was a problem hiding this comment.
Can we make these optional so that if they aren't specified then we just skip the tests. It will be more user friendly to allow them to be optional.
There was a problem hiding this comment.
Also I haven't confirmed if this is the correct way to get the PIXIT codes in - so would need to investigate how this works with the test harness
There was a problem hiding this comment.
I used src/python_testing/TC_RVCRUNM_2_1.py as an example implementation. So not quite sure what is good practice and what is not good practice....
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve and
harimau-qirex
pullapprove
bot
requested review from
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #35566
Implemented test steps 5 to 9.