-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TC_TSTAT_4_2 to work with thermostats that do not have AUTO feature #35579
Merged
mergify
merged 3 commits into
project-chip:master
from
hasty:granbery/thermostat_presets_test_heatcool_fix
Sep 13, 2024
Merged
Update TC_TSTAT_4_2 to work with thermostats that do not have AUTO feature #35579
mergify
merged 3 commits into
project-chip:master
from
hasty:granbery/thermostat_presets_test_heatcool_fix
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 32% smaller than the GitHub diff.
|
hasty
requested review from
ReneJosefsen and
nivi-apple
and removed request for
ReneJosefsen
September 13, 2024 15:11
github-actions
bot
added
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Sep 13, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
September 13, 2024 15:21
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
mspang,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 13, 2024 15:21
fessehaeve
approved these changes
Sep 13, 2024
PR #35579: Size comparison from 7789409 to f7f8947 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
nivi-apple
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Thermostat Presets test script to work with thermostats that only have HEAT or COOL features, and to work with thermostats with the OCC feature when they have set the current occupancy state to not-occupied.