Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ACL XML for MACL and sample conformance #35411

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Fix ACL XML for MACL and sample conformance #35411

merged 12 commits into from
Sep 5, 2024

Conversation

tcarmelveilleux
Copy link
Contributor

Problem:

Issue #35165

  • AccessRestrictionEntryChanged event nees to go away since no longer in spec
  • FabricRestrictionReviewUpdate event has 2 fields that are nullable but need to be optional
  • ReviewFabricRestrictions is missing commands

This PR:

  • Removes dead event AccessRestrictionEntryChanged
  • Sets response command for ReviewFabricRestrictions
  • Sets correct optionality for FabricRestrictionReviewUpdate
  • Sets MGND feature in matter-network-manager-app
  • Remove ResetCounts support command from EthernetNetworkDiagnostics (non conformant)

Testing done:

  • IDM 10.2 and 10.4 pass against matter-network-manager-app with local updated spec XML

@tcarmelveilleux tcarmelveilleux added spec Mismatch between spec and implementation acl Access Control feature hrap quality Software implementation quality labels Sep 4, 2024
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 4, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 6 of 127 files.

Overall, the semantic diff is 17% smaller than the GitHub diff.

File Information
Filename Status
❔ zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/Commands.h Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.h Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/ids/Events.h Unsupported file format
✔️ src/python_testing/TC_ACL_2_11.py 0.26% smaller
❔ src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusters.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusters.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTREventTLVValueDecoder.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.mm Unsupported file format
✔️ src/controller/python/chip/clusters/Objects.py 10.8% smaller
❔ src/controller/java/zap-generated/CHIPEventTLVValueDecoder.cpp Unsupported file format
❔ src/controller/java/src/matter/controller/ICDClientInfo.kt Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/files.gni Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/eventstructs/AccessControlClusterAccessRestrictionEntryChangedEvent.kt Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/eventstructs/AccessControlClusterFabricRestrictionReviewUpdateEvent.kt Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/clusters/AccessControlCluster.kt Unsupported file format
✔️ src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java 10.9% smaller
✔️ src/controller/java/generated/java/chip/devicecontroller/ChipEventStructs.java 11.58% smaller
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java 34.3% smaller
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterInfoMapping.java 34.55% smaller
❔ src/controller/java/generated/java/chip/devicecontroller/cluster/files.gni Unsupported file format
❔ src/controller/java/generated/java/chip/devicecontroller/cluster/eventstructs/AccessControlClusterAccessRestrictionEntryChangedEvent.kt Unsupported file format
❔ src/controller/java/generated/java/chip/devicecontroller/cluster/eventstructs/AccessControlClusterFabricRestrictionReviewUpdateEvent.kt Unsupported file format
❔ src/controller/data_model/controller-clusters.matter Unsupported file format
❔ src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml Unsupported file format
❔ src/app/clusters/access-control-server/access-control-server.cpp Unsupported file format
❔ scripts/tools/zap/tests/outputs/lighting-app/app-templates/access.h Unsupported file format
❔ scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/access.h Unsupported file format
❔ examples/window-app/common/window-app.matter Unsupported file format
❔ examples/virtual-device-app/virtual-device-common/virtual-device-app.matter Unsupported file format
❔ examples/tv-casting-app/tv-casting-common/tv-casting-app.matter Unsupported file format
❔ examples/tv-app/tv-common/tv-app.matter Unsupported file format
❔ examples/thread-br-app/thread-br-common/thread-br-app.matter Unsupported file format
❔ examples/thermostat/thermostat-common/thermostat.matter Unsupported file format
❔ examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter Unsupported file format
❔ examples/thermostat/nxp/zap/thermostat_matter_thread.matter Unsupported file format
❔ examples/thermostat/nxp/zap/thermostat_matter_wifi.matter Unsupported file format
❔ examples/temperature-measurement-app/temperature-measurement-common/temperature-measurement.matter Unsupported file format
❔ examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.matter Unsupported file format
❔ examples/rvc-app/rvc-common/rvc-app.matter Unsupported file format
❔ examples/refrigerator-app/refrigerator-common/refrigerator-app.matter Unsupported file format
❔ examples/pump-controller-app/pump-controller-common/pump-controller-app.matter Unsupported file format
❔ examples/pump-app/silabs/data_model/pump-thread-app.matter Unsupported file format
❔ examples/pump-app/silabs/data_model/pump-wifi-app.matter Unsupported file format
❔ examples/pump-app/pump-common/pump-app.matter Unsupported file format
❔ examples/placeholder/linux/apps/app2/config.matter Unsupported file format
❔ examples/placeholder/linux/apps/app1/config.matter Unsupported file format
❔ examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter Unsupported file format
❔ examples/ota-provider-app/ota-provider-common/ota-provider-app.matter Unsupported file format
❔ examples/network-manager-app/network-manager-common/network-manager-app.matter Unsupported file format
❔ examples/network-manager-app/network-manager-common/network-manager-app.zap Unsupported file format
❔ examples/network-manager-app/linux/include/CHIPProjectAppConfig.h Unsupported file format
❔ examples/microwave-oven-app/microwave-oven-common/microwave-oven-app.matter Unsupported file format
❔ examples/log-source-app/log-source-common/log-source-app.matter Unsupported file format
❔ examples/lock-app/qpg/zap/lock.matter Unsupported file format
❔ examples/lock-app/nxp/zap/lock-app.matter Unsupported file format
❔ examples/lock-app/lock-common/lock-app.matter Unsupported file format
❔ examples/lit-icd-app/lit-icd-common/lit-icd-server-app.matter Unsupported file format
❔ examples/lighting-app-data-mode-no-unique-id/lighting-common/lighting-app.matter Unsupported file format
❔ examples/lighting-app/silabs/data_model/lighting-thread-app.matter Unsupported file format
❔ examples/lighting-app/silabs/data_model/lighting-wifi-app.matter Unsupported file format
❔ examples/lighting-app/qpg/zap/light.matter Unsupported file format
❔ examples/lighting-app/nxp/zap/lighting-on-off.matter Unsupported file format
❔ examples/lighting-app/lighting-common/lighting-app.matter Unsupported file format
❔ examples/lighting-app/bouffalolab/data_model/lighting-app-ethernet.matter Unsupported file format
❔ examples/lighting-app/bouffalolab/data_model/lighting-app-thread.matter Unsupported file format
❔ examples/lighting-app/bouffalolab/data_model/lighting-app-wifi.matter Unsupported file format
❔ examples/light-switch-app/qpg/zap/switch.matter Unsupported file format
❔ examples/light-switch-app/light-switch-common/light-switch-app.matter Unsupported file format
❔ examples/laundry-washer-app/nxp/zap/laundry-washer-app.matter Unsupported file format
❔ examples/fabric-bridge-app/fabric-bridge-common/fabric-bridge-app.matter Unsupported file format
❔ examples/energy-management-app/energy-management-common/energy-management-app.matter Unsupported file format
❔ examples/dishwasher-app/dishwasher-common/dishwasher-app.matter Unsupported file format
❔ examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.matter Unsupported file format
❔ examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.matter Unsupported file format
❔ examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.matter Unsupported file format
❔ examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter Unsupported file format
❔ examples/chef/devices/rootnode_airpurifier_73a6fe2651.matter Unsupported file format
❔ examples/chef/devices/rootnode_airpurifier_airqualitysensor_temperaturesensor_humiditysensor_thermostat_56de3d5f45.matter Unsupported file format
❔ examples/chef/devices/rootnode_airqualitysensor_e63187f6c9.matter Unsupported file format
❔ examples/chef/devices/rootnode_basicvideoplayer_0ff86e943b.matter Unsupported file format
❔ examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter Unsupported file format
❔ examples/chef/devices/rootnode_contactsensor_27f76aeaf5.matter Unsupported file format
❔ examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.matter Unsupported file format
❔ examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter Unsupported file format
❔ examples/chef/devices/rootnode_dimmablepluginunit_f8a9a0b9d4.matter Unsupported file format
❔ examples/chef/devices/rootnode_dishwasher_cc105034fe.matter Unsupported file format
❔ examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter Unsupported file format
❔ examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter Unsupported file format
❔ examples/chef/devices/rootnode_fan_7N2TobIlOX.matter Unsupported file format
❔ examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter Unsupported file format
❔ examples/chef/devices/rootnode_genericswitch_2dfff6e516.matter Unsupported file format
❔ examples/chef/devices/rootnode_genericswitch_9866e35d0b.matter Unsupported file format
❔ examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter Unsupported file format
❔ examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.matter Unsupported file format
❔ examples/chef/devices/rootnode_laundrywasher_fb10d238c8.matter Unsupported file format
❔ examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter Unsupported file format
❔ examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.matter Unsupported file format
❔ examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.matter Unsupported file format
❔ examples/chef/devices/rootnode_onofflight_samplemei.matter Unsupported file format
❔ examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.matter Unsupported file format
❔ examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.matter Unsupported file format
❔ examples/chef/devices/rootnode_pressuresensor_s0qC9wLH4k.matter Unsupported file format
❔ examples/chef/devices/rootnode_pump_5f904818cc.matter Unsupported file format
❔ examples/chef/devices/rootnode_pump_a811bb33a0.matter Unsupported file format
❔ examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter Unsupported file format
❔ examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter Unsupported file format
❔ examples/chef/devices/rootnode_roomairconditioner_9cf3607804.matter Unsupported file format
❔ examples/chef/devices/rootnode_smokecoalarm_686fe0dcb8.matter Unsupported file format
❔ examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter Unsupported file format
❔ examples/chef/devices/rootnode_temperaturesensor_Qy1zkNW7c3.matter Unsupported file format
❔ examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter Unsupported file format
❔ examples/chef/devices/rootnode_waterleakdetector_0b067acfa3.matter Unsupported file format
❔ examples/chef/devices/rootnode_windowcovering_RLCxaGi9Yx.matter Unsupported file format
❔ examples/bridge-app/bridge-common/bridge-app.matter Unsupported file format
❔ examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter Unsupported file format
❔ examples/all-clusters-app/all-clusters-common/all-clusters-app.matter Unsupported file format
❔ examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.matter Unsupported file format
❔ examples/air-purifier-app/air-purifier-common/air-purifier-app.matter Unsupported file format

@github-actions github-actions bot added documentation Improvements or additions to documentation examples scripts darwin controller app github tests matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 labels Sep 4, 2024
@tcarmelveilleux
Fix ACL cluster ZAP XML and regen ZAP
4e29639 
- Remove dead event AccessRestrictionEntryChanged
- Set response command for ReviewFabricRestrictions
- Set correct optionality for FabricRestrictionReviewUpdate
@tcarmelveilleux
Fix access control server after XML change
3b1b0a1
@tcarmelveilleux
Remove unsupportable commnad
887a26e
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

PR #35411: Size comparison from 6144736 to 887a26e

Full report (3 builds for nxp, stm32)
platform target config section 6144736 887a26e change % change
nxp contact k32w1+release FLASH 593248 593248 0 0.0
RAM 62712 62712 0 0.0
light k32w1+release FLASH 676872 676872 0 0.0
RAM 47848 47848 0 0.0
stm32 light STM32WB5MM-DK FLASH 483216 483216 0 0.0
RAM 144740 144740 0 0.0

@tcarmelveilleux tcarmelveilleux added the skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

PR #35411: Size comparison from 6144736 to 42d2856

Full report (5 builds for nxp, stm32, tizen)
platform target config section 6144736 42d2856 change % change
nxp contact k32w1+release FLASH 593248 593248 0 0.0
RAM 62712 62712 0 0.0
light k32w1+release FLASH 676872 676872 0 0.0
RAM 47848 47848 0 0.0
stm32 light STM32WB5MM-DK FLASH 483216 483216 0 0.0
RAM 144740 144740 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1724876 1724868 -8 -0.0
RAM 89500 89500 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17511238 17510486 -752 -0.0
RAM 7601356 7601196 -160 -0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

PR #35411: Size comparison from a5d5f85 to da7fabe

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a5d5f85 da7fabe change % change
bl602 lighting-app bl602 FLASH 1279604 1279596 -8 -0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293458 1293450 -8 -0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318568 1318560 -8 -0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 945190 945190 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679921 679921 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699773 699773 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699773 699773 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656709 656709 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614561 614561 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634197 634197 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634197 634197 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632593 632593 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652309 652309 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652309 652309 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606885 606885 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626737 626737 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626737 626737 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 935316 935316 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740764 740756 -8 -0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017456 1017440 -16 -0.0
RAM 127060 127060 0 0.0
esp32 all-clusters-app c3devkit DRAM 94224 94224 0 0.0
FLASH 1540250 1540250 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115160 115160 0 0.0
FLASH 1550698 1550734 36 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2763665 2763665 0 0.0
RAM 128536 128536 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6078534 6078470 -64 -0.0
RAM 510536 510472 -64 -0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5402956 5402924 -32 -0.0
RAM 240376 240376 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4732472 4732438 -34 -0.0
RAM 217368 217368 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12651040 12649594 -1446 -0.0
RAM 558354 558290 -64 -0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11322876 11321932 -944 -0.0
RAM 608424 608320 -104 -0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10957291 10957087 -204 -0.0
RAM 557354 557290 -64 -0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4555270 4555238 -32 -0.0
RAM 204016 204016 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5684369 5684337 -32 -0.0
RAM 228184 228184 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4787074 4787042 -32 -0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4426612 4426612 0 0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4565198 4565166 -32 -0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3105277 3105245 -32 -0.0
RAM 159168 159168 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4325900 4325892 -8 -0.0
RAM 241896 241896 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6011813 6011813 0 0.0
RAM 583192 583128 -64 -0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10854957 10853501 -1456 -0.0
RAM 645768 645704 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915384 915384 0 0.0
RAM 142243 142243 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886616 886616 0 0.0
RAM 140382 140382 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846812 846812 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 579420 579420 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593248 593248 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615048 615048 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676872 676872 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647932 1647924 -8 -0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551604 1551596 -8 -0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1470396 1470388 -8 -0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463636 1463628 -8 -0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657708 657708 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615880 615880 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 483216 483216 0 0.0
RAM 144740 144740 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620504 620504 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687434 687434 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779874 779874 0 0.0
RAM 110736 110736 0 0.0
bridge-app tlsr9258a FLASH 679496 679496 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622096 622096 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708106 708106 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625734 625734 0 0.0
RAM 145556 145556 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811866 811866 0 0.0
RAM 99480 99480 0 0.0
lock-app-dfu tlsr9528a FLASH 655078 655078 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697362 697362 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631804 631804 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609052 609052 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628882 628882 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653034 653034 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635784 635784 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 523038 523038 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1724876 1724868 -8 -0.0
RAM 89500 89500 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17511294 17510542 -752 -0.0
RAM 7601388 7601228 -160 -0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

PR #35411: Size comparison from a5d5f85 to c2b9e78

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a5d5f85 c2b9e78 change % change
bl602 lighting-app bl602 FLASH 1279604 1279596 -8 -0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293458 1293450 -8 -0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318568 1318560 -8 -0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 945190 945190 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679921 679921 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699773 699773 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699773 699773 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656709 656709 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614561 614561 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634197 634197 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634197 634197 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632593 632593 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652309 652309 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652309 652309 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606885 606885 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626737 626737 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626737 626737 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 935316 935316 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740764 740756 -8 -0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017456 1017440 -16 -0.0
RAM 127060 127060 0 0.0
esp32 all-clusters-app c3devkit DRAM 94224 94224 0 0.0
FLASH 1540250 1540250 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115160 115160 0 0.0
FLASH 1550698 1550734 36 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2763665 2763665 0 0.0
RAM 128536 128536 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6078534 6078470 -64 -0.0
RAM 510536 510472 -64 -0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5402956 5402924 -32 -0.0
RAM 240376 240376 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4732472 4732438 -34 -0.0
RAM 217368 217368 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12651040 12649594 -1446 -0.0
RAM 558354 558290 -64 -0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11322876 11321932 -944 -0.0
RAM 608424 608320 -104 -0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10957291 10957087 -204 -0.0
RAM 557354 557290 -64 -0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4555270 4555238 -32 -0.0
RAM 204016 204016 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5684369 5684337 -32 -0.0
RAM 228184 228184 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4787074 4787042 -32 -0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4426612 4426612 0 0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4565198 4565166 -32 -0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3105277 3105245 -32 -0.0
RAM 159168 159168 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4325900 4325892 -8 -0.0
RAM 241896 241896 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6011813 6011813 0 0.0
RAM 583192 583128 -64 -0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10854957 10853501 -1456 -0.0
RAM 645768 645704 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915384 915384 0 0.0
RAM 142243 142243 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886616 886616 0 0.0
RAM 140382 140382 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846812 846812 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 579420 579420 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593248 593248 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615048 615048 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676872 676872 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647932 1647924 -8 -0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551604 1551596 -8 -0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1470396 1470388 -8 -0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463636 1463628 -8 -0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657708 657708 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615880 615880 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 483216 483216 0 0.0
RAM 144740 144740 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620504 620504 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687434 687434 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779874 779874 0 0.0
RAM 110736 110736 0 0.0
bridge-app tlsr9258a FLASH 679496 679496 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622096 622096 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708106 708106 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625734 625734 0 0.0
RAM 145556 145556 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811866 811866 0 0.0
RAM 99480 99480 0 0.0
lock-app-dfu tlsr9528a FLASH 655078 655078 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697362 697362 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631804 631804 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609052 609052 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628882 628882 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653034 653034 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635784 635784 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 523038 523038 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1724876 1724868 -8 -0.0
RAM 89500 89500 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17511294 17510542 -752 -0.0
RAM 7601388 7601228 -160 -0.0

@tcarmelveilleux tcarmelveilleux mentioned this pull request Sep 4, 2024
Open
@mergify mergify bot merged commit 58ed63d into project-chip:master Sep 5, 2024
70 checks passed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Sep 10, 2024
@tcarmelveilleux @restyled-commits @shgutte
Fix ACL XML for MACL and sample conformance (project-chip#35411)
3fc2056 
* Fix ACL cluster ZAP XML and regen ZAP

- Remove dead event AccessRestrictionEntryChanged
- Set response command for ReviewFabricRestrictions
- Set correct optionality for FabricRestrictionReviewUpdate

* Fix access control server after XML change

* Remove unsupportable commnad

* Rename RedirectURL field to ARLRequestFlowUrl

* Kick CI

* Kick CI

* Remove non-longer-applicable files

* Increase size of event buffer pool in NIM sample

* Restyled by clang-format

* Fix format

* Remove subscription for event that no longer exists

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecille cecille cecille approved these changes

@tleacmcsa tleacmcsa tleacmcsa approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@chapongatien chapongatien Awaiting requested review from chapongatien

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
acl Access Control feature app controller darwin documentation Improvements or additions to documentation examples github hrap matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 quality Software implementation quality review - approved scripts skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped spec Mismatch between spec and implementation tests
Projects
[Device Type] Routers & Access Points
Status: Done
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tcarmelveilleux @cecille @tleacmcsa @chrisdecenzo @bzbarsky-apple @restyled-commits