-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Matter Linux Water Leak Detector Example #35392
Conversation
Remote Echo protocol section
Review changes with SemanticDiff. Analyzed 4 of 13 files.
|
PR #35392: Size comparison from 30cff8e to 4026aa0 Full report (7 builds for nxp, qpg, stm32, tizen)
|
PR #35392: Size comparison from 30cff8e to e22d4c3 Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
Fix typo
PR #35392: Size comparison from 30cff8e to 1882b76 Full report (7 builds for nxp, qpg, stm32, tizen)
|
PR #35392: Size comparison from 30cff8e to abc1ab4 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
Remove last line
PR #35392: Size comparison from 30cff8e to 42d21b4 Full report (39 builds for bl602, bl702, bl702l, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
PR #35392: Size comparison from 30cff8e to 0b1e3f9 Full report (22 builds for bl602, bl702, bl702l, nrfconnect, nxp, qpg, stm32, tizen)
|
PR #35392: Size comparison from 30cff8e to b451013 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35392: Size comparison from a643be6 to 889feec Full report (3 builds for cc32xx, stm32)
|
PR #35392: Size comparison from a643be6 to 1e754d4 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35392: Size comparison from 8323604 to 6dd7fc6 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Is everything in order for validation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add support for this to build_examples (you have to change targets.py and host.py at least)
Also without CI this may become stale ...are we sure we want no CI here?
Last 2 commits should fix this. |
PR #35392: Size comparison from 20200ee to 931905e Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
Fix ThreeLevelAutoEnum
Add water-leak-detector
PR #35392: Size comparison from 20200ee to 79b97a9 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
] | ||
}, | ||
{ | ||
"name": "Power Source", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be on ep0.
"parentEndpointIdentifier": null | ||
}, | ||
{ | ||
"endpointTypeName": "Anonymous Endpoint Type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
"endpointTypeName": "Anonymous Endpoint Type", | |
"endpointTypeName": "MA-water-leak-detector", |
@lboue can you please address my comments as a follow-up? |
Add Linux Matter Linux Water Leak Detector Example