[Linux] Matter Linux Water Leak Detector Example #35392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote Echo protocol section
|
Review changes with SemanticDiff. Analyzed 4 of 13 files.
|
|
PR #35392: Size comparison from 30cff8e to 4026aa0 Full report (7 builds for nxp, qpg, stm32, tizen)
|
|
PR #35392: Size comparison from 30cff8e to e22d4c3 Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
Fix typo
|
PR #35392: Size comparison from 30cff8e to 1882b76 Full report (7 builds for nxp, qpg, stm32, tizen)
|
|
PR #35392: Size comparison from 30cff8e to abc1ab4 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
Remove last line
|
PR #35392: Size comparison from 30cff8e to 42d21b4 Full report (39 builds for bl602, bl702, bl702l, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35392: Size comparison from 30cff8e to 0b1e3f9 Full report (22 builds for bl602, bl702, bl702l, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35392: Size comparison from 30cff8e to b451013 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan and
bzbarsky-apple
|
PR #35392: Size comparison from a643be6 to 889feec Full report (3 builds for cc32xx, stm32)
|
|
PR #35392: Size comparison from a643be6 to 1e754d4 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35392: Size comparison from 8323604 to 6dd7fc6 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Is everything in order for validation? |
andy31415
previously requested changes
Oct 2, 2024
Last 2 commits should fix this. |
|
PR #35392: Size comparison from 20200ee to 931905e Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
Fix ThreeLevelAutoEnum
Add water-leak-detector
|
PR #35392: Size comparison from 20200ee to 79b97a9 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 3, 2024
fessehaeve
approved these changes
Oct 7, 2024
fessehaeve
requested changes
Oct 7, 2024
| ] | ||
| }, | ||
| { | ||
| "name": "Power Source", |
| "parentEndpointIdentifier": null | ||
| }, | ||
| { | ||
| "endpointTypeName": "Anonymous Endpoint Type", |
There was a problem hiding this comment.
should be
Suggested change
| "endpointTypeName": "Anonymous Endpoint Type", | |
| "endpointTypeName": "MA-water-leak-detector", |
|
@lboue can you please address my comments as a follow-up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Linux Matter Linux Water Leak Detector Example