[Silabs] Wi-fi: Header and source dhcp files cleanup #35143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
|
|
PR #35143: Size comparison from 4aac314 to f0125d5 Full report (41 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35143: Size comparison from 4aac314 to fb2b3c7 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35143: Size comparison from 4aac314 to ab40dc3 Increases above 0.2%:
Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
senthilku
reviewed
Aug 23, 2024
bhmanda-silabs
force-pushed
the
cleanup/duplicated_dhcp_client_files
branch
from
8eadb89
to
ff26469
Compare
|
PR #35143: Size comparison from cfdbba9 to ff26469 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
|
PR #35143: Size comparison from 6837162 to afec840 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rosahay-silabs
approved these changes
Aug 29, 2024
senthilku
approved these changes
Aug 30, 2024
|
PR #35143: Size comparison from dd87540 to 9e9add8 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35143: Size comparison from 0e3434a to 3bf6bb4 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35143: Size comparison from 4c5fa19 to 416e8ac Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Aug 30, 2024
jmartinez-silabs
added
the
changing-submodules-on-purpose
jmartinez-silabs
force-pushed
the
cleanup/duplicated_dhcp_client_files
branch
from
416e8ac
to
a203f2b
Compare
|
PR #35143: Size comparison from 9946fc8 to a203f2b Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bhmanda-silabs
force-pushed
the
cleanup/duplicated_dhcp_client_files
branch
from
a203f2b
to
0f9d1ac
Compare
|
PR #35143: Size comparison from 2cf028b to 0f9d1ac Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chirag-silabs
approved these changes
Sep 5, 2024
|
PR #35143: Size comparison from 7d57f07 to 635d38a Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated dhcp_client.cpp and dhcp_client.h files removed.
Compiled for BRD4187C+SiWX917 NCP and BRD4338A SoC