Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DuplicatedAreas error #35126

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Remove DuplicatedAreas error #35126

merged 6 commits into from
Aug 23, 2024

Conversation

hicklin
Copy link
Contributor

@hicklin hicklin commented Aug 21, 2024

Fixes #35014.

This PR

  • Removes the DuplicateAreas error form the SelectAreasStatus enum in the XML.
  • Regenerates code.
  • Updates the Service Area server code and test script to match the updates in the spec and test plan.
    • Updates the the HandleSelectAreasCmd
    • Updates the RVC example app
    • Updates the SEAR 1.3 test script

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 21, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 2 of 12 files.

Overall, the semantic diff is 61% smaller than the GitHub diff.

Filename Status
❔ zzz_generated/app-common/app-common/zap-generated/cluster-enums-check.h Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-enums.h Unsupported file format
✔️ src/python_testing/TC_SEAR_1_3.py 62.22% smaller
❔ src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
✔️ src/controller/python/chip/clusters/Objects.py 56.08% smaller
❔ src/controller/data_model/controller-clusters.matter Unsupported file format
❔ src/app/zap-templates/zcl/data-model/chip/service-area-cluster.xml Unsupported file format
❔ src/app/clusters/service-area-server/service-area-delegate.h Unsupported file format
❔ src/app/clusters/service-area-server/service-area-server.cpp Unsupported file format
❔ examples/rvc-app/rvc-common/rvc-app.matter Unsupported file format
❔ examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp Unsupported file format
❔ examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h Unsupported file format

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

PR #35126: Size comparison from 8b97b28 to 50da0c2

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8b97b28 50da0c2 change % change
bl602 lighting-app bl602 FLASH 1278282 1278282 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292392 1292392 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317246 1317246 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944186 944186 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 946586 946586 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039242 1039242 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 646848 646848 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894448 894448 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 960590 960590 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963468 963468 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672465 672465 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692325 692325 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692325 692325 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649261 649261 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610929 610929 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630557 630557 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630557 630557 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 628969 628969 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648677 648677 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648677 648677 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601917 601917 0 0.0
RAM 68340 68340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621777 621777 0 0.0
RAM 70972 70972 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621777 621777 0 0.0
RAM 70972 70972 0 0.0
efr32 lighting-app BRD4187C FLASH 930564 930564 0 0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740564 740556 -8 -0.0
RAM 208488 208488 0 0.0
window-app BRD4187C FLASH 1015656 1015656 0 0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94192 94192 0 0.0
FLASH 1532632 1532632 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115128 115128 0 0.0
FLASH 1542398 1542398 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2755419 2755419 0 0.0
RAM 128408 128408 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6037850 6037850 0 0.0
RAM 509736 509704 -32 -0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5377354 5377354 0 0.0
RAM 240104 240104 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4729216 4729216 0 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12488672 12488640 -32 -0.0
RAM 557202 557170 -32 -0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11164300 11164284 -16 -0.0
RAM 607272 607240 -32 -0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10859615 10859583 -32 -0.0
RAM 555402 555370 -32 -0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4550056 4550056 0 0.0
RAM 203648 203648 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5663777 5663777 0 0.0
RAM 228008 228008 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4784562 4784562 0 0.0
RAM 203736 203736 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4424036 4424036 0 0.0
RAM 197720 197720 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4562654 4562654 0 0.0
RAM 202256 202256 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3075197 3075197 0 0.0
RAM 158936 158936 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4364340 4364340 0 0.0
RAM 242416 242416 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6007061 6007061 0 0.0
RAM 582968 582936 -32 -0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10692765 10692765 0 0.0
RAM 644280 644248 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 909344 909344 0 0.0
RAM 142211 142211 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 881120 881120 0 0.0
RAM 140350 140350 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841176 841176 0 0.0
RAM 141030 141030 0 0.0
nxp contact k32w0+release FLASH 577580 577580 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590208 590208 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613008 613008 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 674880 674880 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1639508 1639508 0 0.0
RAM 210904 210904 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1544260 1544260 0 0.0
RAM 207624 207624 0 0.0
light cy8ckit_062s2_43012 FLASH 1464028 1464028 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463236 1463236 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656116 656116 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 613992 613992 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478472 478472 0 0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620280 620280 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 680860 680860 0 0.0
RAM 149544 149544 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 774168 774168 0 0.0
RAM 110704 110704 0 0.0
bridge-app tlsr9258a FLASH 679010 679010 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621872 621872 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707762 707762 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620758 620758 0 0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806930 806930 0 0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 654854 654854 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697026 697026 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631318 631318 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608828 608828 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628662 628662 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652698 652698 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 633882 633882 0 0.0
RAM 53392 53392 0 0.0
window-covering tlsr9118bdk40d FLASH 522774 522774 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4820 4820 0 0.0
FLASH 1701560 1701560 0 0.0
RAM 89300 89300 0 0.0
chip-tool-ubsan arm unknown 10252 10252 0 0.0
FLASH 17308510 17308502 -8 -0.0
RAM 7561280 7561256 -24 -0.0

bzbarsky-apple
bzbarsky-apple approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming the text noted at https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10254#discussion_r1725535472 doesn't actually say what it means to say.

src/app/clusters/service-area-server/service-area-delegate.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

PR #35126: Size comparison from 8b97b28 to 8757886

Increases above 0.2%:

platform target config section 8b97b28 8757886 change % change
linux chip-tool debug FLASH 12488672 12646418 157746 1.3
chip-tool-ipv6only arm64 FLASH 11164300 11318988 154688 1.4
fabric-admin debug FLASH 10859615 10925769 66154 0.6
tv-casting-app debug FLASH 10692765 10851069 158304 1.5
RAM 644280 645720 1440 0.2
tizen chip-tool-ubsan arm FLASH 17308510 17492422 183912 1.1
RAM 7561280 7599476 38196 0.5
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8b97b28 8757886 change % change
bl602 lighting-app bl602 FLASH 1278282 1278182 -100 -0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292392 1292292 -100 -0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317246 1317146 -100 -0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944186 944224 38 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 946586 946624 38 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039242 1039536 294 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 646848 647142 294 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894448 894492 44 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 960590 960884 294 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963468 963506 38 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672465 672417 -48 -0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692325 692277 -48 -0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692325 692277 -48 -0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649261 649213 -48 -0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610929 610929 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630557 630557 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630557 630557 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 628969 628969 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648677 648677 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648677 648677 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601917 601989 72 0.0
RAM 68340 68340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621777 621849 72 0.0
RAM 70972 70972 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621777 621849 72 0.0
RAM 70972 70972 0 0.0
efr32 lighting-app BRD4187C FLASH 930564 930500 -64 -0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740564 740556 -8 -0.0
RAM 208488 208488 0 0.0
window-app BRD4187C FLASH 1015656 1015656 0 0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94192 94192 0 0.0
FLASH 1532632 1532618 -14 -0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115128 115128 0 0.0
FLASH 1542398 1542570 172 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2755419 2756149 730 0.0
RAM 128408 128408 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6037850 6040396 2546 0.0
RAM 509736 509896 160 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5377354 5379084 1730 0.0
RAM 240104 240104 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4729216 4729230 14 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12488672 12646418 157746 1.3
RAM 557202 558290 1088 0.2
chip-tool-ipv6only arm64 unknown 20312 20352 40 0.2
FLASH 11164300 11318988 154688 1.4
RAM 607272 608336 1064 0.2
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10859615 10925769 66154 0.6
RAM 555402 556490 1088 0.2
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4550056 4550190 134 0.0
RAM 203648 203648 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5663777 5665281 1504 0.0
RAM 228008 228008 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4784562 4784576 14 0.0
RAM 203736 203736 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4424036 4424050 14 0.0
RAM 197720 197720 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4562654 4562668 14 0.0
RAM 202256 202256 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3075197 3077293 2096 0.1
RAM 158936 158936 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4364340 4364996 656 0.0
RAM 242416 242416 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6007061 6007141 80 0.0
RAM 582968 583128 160 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10692765 10851069 158304 1.5
RAM 644280 645720 1440 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 909344 909444 100 0.0
RAM 142211 142211 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 881120 881332 212 0.0
RAM 140350 140350 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841176 841188 12 0.0
RAM 141030 141030 0 0.0
nxp contact k32w0+release FLASH 577580 577580 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590208 590208 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613008 613008 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 674880 674880 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1639508 1639684 176 0.0
RAM 210904 210904 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1544260 1544372 112 0.0
RAM 207624 207624 0 0.0
light cy8ckit_062s2_43012 FLASH 1464028 1464188 160 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463236 1463236 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656116 656068 -48 -0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 613992 613992 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478472 478424 -48 -0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620280 620280 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 680860 680850 -10 -0.0
RAM 149544 149544 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 774168 774178 10 0.0
RAM 110704 110704 0 0.0
bridge-app tlsr9258a FLASH 679010 679010 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621872 621872 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707762 707762 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620758 620560 -198 -0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806930 806732 -198 -0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 654854 654854 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697026 697026 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631318 631318 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608828 608828 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628662 628662 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652698 652698 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 633882 633974 92 0.0
RAM 53392 53392 0 0.0
window-covering tlsr9118bdk40d FLASH 522774 522774 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4820 4820 0 0.0
FLASH 1701560 1703568 2008 0.1
RAM 89300 89300 0 0.0
chip-tool-ubsan arm unknown 10252 10272 20 0.2
FLASH 17308510 17492422 183912 1.1
RAM 7561280 7599476 38196 0.5

@mergify mergify bot merged commit 010d982 into project-chip:master Aug 23, 2024
68 checks passed
PeterC1965 pushed a commit to PeterC1965/connectedhomeip that referenced this pull request Aug 28, 2024
@hicklin @restyled-commits @PeterC1965
Remove DuplicatedAreas error (project-chip#35126)
fdc8cce 
* Removed the DuplicatedAreas error from the XML

* Generated code after XML update.

* The service are server ignores any duplicate values before calling the delegate. Example was updated accodingly.

* Updated test SEAR-1.3 following changes to the duplicated areas error.

* Restyled by clang-format

* Made select areas const.

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 review - approved tests
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove DuplicatedAreas error and update logic
4 participants
@hicklin @bzbarsky-apple @jmartinez-silabs @restyled-commits