Add chip_logging_backend option and 'none' and 'syslog' backends #34830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename from Logging.cpp to Stdio.cpp and add license header.
chip_logging_backend controls which backend is pulled in by the src/platform/logging:default target. The default is 'platform', retaining the current behavior. On Darwin, remove the no-op LoggingImpl and make stdio the default backend when compiling tools or example apps. Use the new 'none' backend when building Matter.framework, retaining current behavior. Depend on logging:default instead of logging:stdio for linux:app-main examples.
|
Review changes with SemanticDiff. |
|
PR #34830: Size comparison from 212d6ab to 6c1d4b7 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
The stdio and linux backends use slightly different output formats and the cirque tests currently only parse the stdio format correctly.
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #34830: Size comparison from 212d6ab to 09cac5e Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32)
|
|
PR #34830: Size comparison from 212d6ab to cfa7179 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
chapongatien,
chrisdecenzo and
chshu
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
bzbarsky-apple
approved these changes
Aug 7, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…ject-chip#34830) * Tidy up stdio logging target dependencies Also rename from Logging.cpp to Stdio.cpp and add license header. * Add chip_logging_backend option and 'none' backend chip_logging_backend controls which backend is pulled in by the src/platform/logging:default target. The default is 'platform', retaining the current behavior. On Darwin, remove the no-op LoggingImpl and make stdio the default backend when compiling tools or example apps. Use the new 'none' backend when building Matter.framework, retaining current behavior. Depend on logging:default instead of logging:stdio for linux:app-main examples. * Add a syslog logging backend * Fix STM32 build * Use stdio logging backend for cirque tests The stdio and linux backends use slightly different output formats and the cirque tests currently only parse the stdio format correctly. * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fix stray space in GN string comparison --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chip_logging_backendcontrols which backend is pulled in by thesrc/platform/logging:defaulttarget. The default is 'platform', retaining the current behavior.On Darwin, remove the no-op
LoggingImpland make stdio the default backend when compiling tools or example apps.Use the new 'none' backend when building Matter.framework, retaining current behavior.
Depend on
logging:defaultinstead oflogging:stdiofor linux:app-main examples so the backend can be selected at build time viachip_logging_backend.