Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BDX transfer support for Python tests #34821
base: master
Are you sure you want to change the base?
BDX transfer support for Python tests #34821
Changes from 37 commits
19436f1
a0687c1
f798bd8
beb87c5
0a73a52
dd1b3c7
6d0fe4f
9748281
0cd39c3
de7c762
18449f5
f51e192
b0603ae
79c7483
17dcf11
c8201bb
727ecbe
dc4c2aa
a7b40dd
10973ff
df7ea6c
7c5fe88
84be6ab
5ca363a
92cd2c8
ff38946
a03d1ad
f921aab
39218dd
7a2f298
68e10ed
36ea7ae
186efcd
5a28be5
c979d9d
fff7994
0b4092f
420a913
59cc705
bdab8b4
f4790d0
9d76978
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a type annotation for data? Is it expecting bytes? or string? or something else entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Or not self._data if data can't be a thing that evaluates to false. Not sure on the data type or whether an empty data is viable.