Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Ecosystem Information Cluster to use global structs #34744

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Migrate Ecosystem Information Cluster to use global structs #34744

merged 3 commits into from
Aug 2, 2024

Conversation

tehampson
Copy link
Contributor

No description provided.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added the app label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

PR #34744: Size comparison from c124b81 to ed3ca08

Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
platform target config section c124b81 ed3ca08 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802368 802368 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818316 818316 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810600 810600 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762804 762804 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747456 747456 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610142 610142 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654446 654446 0 0.0
RAM 205620 205620 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505388 1505388 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906560 906560 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879556 879556 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838280 838280 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576412 576412 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592136 592136 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612056 612056 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 676968 676968 0 0.0
RAM 83232 83232 0 0.0
qpg lighting-app qpg6105+debug FLASH 655124 655124 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612560 612560 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477496 477496 0 0.0
RAM 144756 144756 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1701460 1701460 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16607618 16607618 0 0.0
RAM 7297180 7297180 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

PR #34744: Size comparison from 138b5b8 to 46c085f

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 138b5b8 46c085f change % change
bl602 lighting-app bl602 FLASH 1277760 1277760 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292018 1292018 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1316728 1316728 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098904 1098904 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109598 1109598 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1188970 1188970 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881938 881938 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135116 1135116 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086066 1086066 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097072 1097072 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802704 802704 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818652 818652 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810936 810936 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763132 763132 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747784 747784 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610542 610542 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654846 654846 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671777 671777 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691637 691637 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691637 691637 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648565 648565 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610417 610417 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630053 630053 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630053 630053 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627785 627785 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647501 647501 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647501 647501 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599885 599885 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619737 619737 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619737 619737 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929744 929744 0 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737180 737172 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015540 1015540 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1530542 1530542 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1541126 1541126 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2746547 2746547 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6027690 6027690 0 0.0
RAM 509904 509904 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5367580 5367580 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727326 4727326 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12496588 12496588 0 0.0
RAM 558362 558362 0 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11174028 11174028 0 0.0
RAM 608320 608320 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11474831 11474831 0 0.0
RAM 555098 555098 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483348 4483348 0 0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661393 5661393 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782156 4782156 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422470 4422470 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560616 4560616 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3066781 3066781 0 0.0
RAM 158952 158952 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4357396 4357396 0 0.0
RAM 242216 242216 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004661 6004661 0 0.0
RAM 583552 583552 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10701117 10701117 0 0.0
RAM 645608 645608 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505796 1505796 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906920 906920 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879492 879492 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838636 838636 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576716 576716 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592440 592440 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612376 612376 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677264 677264 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1636108 1636108 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1541244 1541244 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463476 1463476 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462204 1462204 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655484 655484 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612920 612920 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477832 477832 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619760 619760 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678550 678550 0 0.0
RAM 149556 149556 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 771784 771784 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678374 678374 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621352 621352 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707216 707216 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620140 620140 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806226 806226 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654102 654102 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696408 696408 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630708 630708 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608308 608308 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628120 628120 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652130 652130 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631896 631896 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 522270 522270 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705172 1705172 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619658 16619658 0 0.0
RAM 7303836 7303836 0 0.0

@mergify mergify bot merged commit da6dd90 into project-chip:master Aug 2, 2024
69 checks passed
w8floosh pushed a commit to w8floosh/chip-fuzzing that referenced this pull request Aug 4, 2024
@tehampson @restyled-commits
Migrate Ecosystem Information Cluster to use global structs (project-…
68f6b71 
…chip#34744)

* Migrate Ecosystem Information Cluster to use global structs

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
@hicklin hicklin mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samadDotDev samadDotDev samadDotDev approved these changes

@saurabhst saurabhst saurabhst approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tehampson @samadDotDev @saurabhst @bzbarsky-apple @restyled-commits