Add water heater management cluster sdk support #34339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NFIG_ENABLE_WATER_HEATER_MANAGEMENT_TRIGGER
jamesharrow
reviewed
Jul 15, 2024
|
PR #34339: Size comparison from 049f5b2 to 624d9c6 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34339: Size comparison from 049f5b2 to be2a49c Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
jamesharrow
approved these changes
Jul 15, 2024
|
PR #34339: Size comparison from 049f5b2 to ca7ad50 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien and
chrisdecenzo
tcarmelveilleux
dismissed
their stale review
Changess addressed, but going on vacation
|
PR #34339: Size comparison from b88ac27 to 2c43cf0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 18, 2024
|
PR #34339: Size comparison from 3bc5667 to d38c545 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34339: Size comparison from f6022e4 to b10398c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34339: Size comparison from c91a779 to cf319aa Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34339: Size comparison from ba949bf to 46cd339 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34339: Size comparison from a5124a9 to e458e09 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34339: Size comparison from f4d9188 to a167c34 Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nrfconnect, nxp, psoc6, stm32, telink, tizen)
|
|
PR #34339: Size comparison from 44c725d to 628dd91 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
18 tasks
doru91
approved these changes
Jul 29, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add base water-heater-mode-cluster support into control files and regenerate files * Add support for the water-heater-management cluster SDK * Add support for the water-heater-management cluster SDK * Add support for the water-heater-management cluster SDK * Add support for the water-heater-management cluster SDK * Define chip_enable_water_heater_management_trigger and CHIP_DEVICE_CONFIG_ENABLE_WATER_HEATER_MANAGEMENT_TRIGGER * Restyled by isort * Add accidentally deleted Mode_WaterHeater.xml back * Address review comments from Tennessee Carmel-Veilleux * Add WaterHeaterManagementTestEventTriggerHandler.h * Apply various review comments from Boris Zbarsky * Apply various review comments from Boris Zbarsky * Addressing review comments from Boris * Addressing review comments from Boris * Restyled by whitespace * Restyled by clang-format * Address review comment from Tennessee * Update with review comments from Boris * Fix compilation introduced during merge --------- Co-authored-by: Restyled.io <commits@restyled.io>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add base water-heater-mode-cluster support into control files and regenerate files * Add support for the water-heater-management cluster SDK * Add support for the water-heater-management cluster SDK * Add support for the water-heater-management cluster SDK * Add support for the water-heater-management cluster SDK * Define chip_enable_water_heater_management_trigger and CHIP_DEVICE_CONFIG_ENABLE_WATER_HEATER_MANAGEMENT_TRIGGER * Restyled by isort * Add accidentally deleted Mode_WaterHeater.xml back * Address review comments from Tennessee Carmel-Veilleux * Add WaterHeaterManagementTestEventTriggerHandler.h * Apply various review comments from Boris Zbarsky * Apply various review comments from Boris Zbarsky * Addressing review comments from Boris * Addressing review comments from Boris * Restyled by whitespace * Restyled by clang-format * Address review comment from Tennessee * Update with review comments from Boris * Fix compilation introduced during merge --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add water heater management cluster SDK support (issue Fixes #34250)
The water heater management cluster spec can be found here:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/WaterHeaterManagement.adoc
This PR follows on from #34333.
There will be further PRs for the water heater management example application and test cases.