[Fix] Possible fix for matter-test-scripts issue #227: Remove PICS from OPSTATE tests #34290
+189
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-ororke
commented
Jul 10, 2024
j-ororke
commented
- Removed PICS checks in TC_OpstateCommon.py module and replaced with attribute and command checks from connected endpoint during tests.
- Removed PICS checks and replaced with attribute and command checks from endpoint during tests.
|
PR #34290: Size comparison from 3c96d5b to d10612e Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
- Removed some variables that were no longer needed
|
PR #34290: Size comparison from 3c96d5b to 832661a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
2 tasks
- Removed automatable PICS checks and replaced with attributes available to be gathered from endpoint.
|
PR #34290: Size comparison from 3c96d5b to 53f6afb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Adding back in missing time import and test runner comments into test module
- Replaced input() with wait_for_user_input() in test script - Added back in short sleep to script, not sure why it got removed.
|
PR #34290: Size comparison from 3c96d5b to e30aefa Full report (3 builds for cc32xx, stm32)
|
|
PR #34290: Size comparison from 3c96d5b to 084a115 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Had to remove "test_step" variable that was attempting to be called in wait_for_user_input() as it was not being defined earlier in the test module.
|
PR #34290: Size comparison from 3c96d5b to 3c2ba60 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
- Minor change to remove unneeded f-string from wait_for_user_input().
|
PR #34290: Size comparison from 3c96d5b to ec31380 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille and
chapongatien
|
PR #34290: Size comparison from 8750c55 to 1f8af58 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Resolved linting errors
|
PR #34290: Size comparison from 941c1d2 to a441b26 Full report (19 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34290: Size comparison from 941c1d2 to 6b61a00 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34290: Size comparison from 9c6c365 to fd714b8 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34290: Size comparison from 9c6c365 to f090844 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Debugging to find issue why test is failing in CI pipeline.
|
PR #34290: Size comparison from 9c6c365 to 78f6e4e Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Continuing effort to resolve issue with CI pipeline
|
PR #34290: Size comparison from 9c6c365 to b972df9 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
removed
the
matter-1.4-te2-script-change
… remove_PICS_from_OPSTATE_tests
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #34290: Size comparison from 5c0c92e to 354f40a Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
removed
the
matter-1.4-te2-script-change
- Resolved issues with attributes_guard function in matter_testing support module
github-actions
bot
added
the
matter-1.4-te2-script-change
- changed verbosity in CI arguments to make it quieter.
|
PR #34290: Size comparison from 5c0c92e to bb54582 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.