Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the groups and scenes clusters from C to C++. #3427

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Oct 23, 2020

Problem

We likely want to create a C++ API for #2168 and these clusters need to read from buffers.

Summary of Changes

Rename files from .c to .cpp

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .dram0.bss 0 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,21319
.debug_line,0,4592
.debug_abbrev,0,2325
.debug_str,0,432
.strtab,0,204
.debug_loc,0,76
.debug_ranges,0,48
.dram0.bss,-8,0


@bzbarsky-apple
Copy link
Contributor Author

@bzbarsky-apple bzbarsky-apple merged commit 2e27d8f into project-chip:master Oct 24, 2020
@bzbarsky-apple bzbarsky-apple deleted the convert-clusters-cpp branch October 24, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants