Re-Implement App Install flow #34141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
lazarkov
force-pushed
the
feature/app-install-flow-public
branch
from
069c6d3
to
4dc7661
Compare
lazarkov
force-pushed
the
feature/app-install-flow-public
branch
from
2d76132
to
77f30ee
Compare
|
PR #34141: Size comparison from 587665d to 8d30c4e Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34141: Size comparison from 587665d to 4017d57 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 8, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
* Add install things * Update the code * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format * Restyled by gn * Revert the unecessary changes * Remove uncessary files * Update comment * Restyled by google-java-format * Fix get catalog list * Added option to log the content apps * Restyled by google-java-format * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Implementing application installation flow. Continuation of #33959
The PR also covers a spec update: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10014
Problem
Current application installation flow blocks commissioning and has too crude functionality that cannot provide great UX (providing installation percentage etc.)
Change overview
Tests - Android - App Install & Get Catalog List
Build the Android TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/Build the TV casting app using command:
scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/Start TV Android App
Start TV Casting App
out/debug/chip-tv-casting-appSend Application Launcher command
cast cluster applicationlauncher launch-app 0 1 --Application {"catalogVendorID":123,"applicationID":"com.example.contentapp"}You should receive pending state:
{ status: 3, data: "" }Start the app install of content app and send application launcher command again, where you should receive installing state:
{ status: 4, data: "" }In case app install failed and you send application launcher command, you should then receive the state:
{ status: 3, data: 41707020696E7374616C6C206661696C65642E2054727920616761696E }The byte value stands for: "App install failed. Try again"
Finally you can test reading of catalog list by sending Application Launcher command
cast cluster applicationlauncher read catalog-list 0 1it results in: