Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BLE UUID string constants lowercase #33692

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Make BLE UUID string constants lowercase #33692

merged 2 commits into from
Jun 3, 2024

Conversation

andy31415
Copy link
Contributor

I was failing to provision ble-wifi from linux after #33649. It seems that turning string constants to lowercase makes it work (previous code had it lowercase).

I could not really find documentation in bluez about the case requirement though. All I see is that:

    GAutoPtr<GVariant> dataValue(g_variant_lookup_value(serviceData, Ble::CHIP_BLE_SERVICE_LONG_UUID_STR, nullptr));
    VerifyOrReturnError(dataValue != nullptr, false);

fails with uppercase and succeeds with lowercase, so it seems to me that service data is a map with lowercase keys.

@github-actions github-actions bot added the ble label May 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

PR #33692: Size comparison from b790232 to 31717b5

Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section b790232 31717b5 change % change
bl602 lighting-app bl602 (read/write) 1444010 1444010 0 0.0
.bss 85896 85896 0 0.0
.data 9512 9512 0 0.0
.rodata 160028 160028 0 0.0
.text 1107918 1107918 0 0.0
bl602+mfd (read/write) 1458706 1458706 0 0.0
.bss 86072 86072 0 0.0
.data 9488 9488 0 0.0
.rodata 158988 158988 0 0.0
.text 1123492 1123492 0 0.0
bl602+rpc (read/write) 1491682 1491682 0 0.0
.bss 93944 93944 0 0.0
.data 9896 9896 0 0.0
.rodata 167604 167604 0 0.0
.text 1139564 1139564 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210115 1210115 0 0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 109580 109580 0 0.0
.text 978578 978578 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220927 1220927 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 108520 108520 0 0.0
.text 990332 990332 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301331 1301331 0 0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124952 124952 0 0.0
.text 1053030 1053030 0 0.0
bl706-eth (read/write) 1027461 1027461 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 102596 102596 0 0.0
.text 769382 769382 0 0.0
bl706-wifi (read/write) 1261138 1261138 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 123716 123716 0 0.0
.text 1000156 1000156 0 0.0
bl702l lighting-app bl702l (read/write) 1179960 1179960 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 103584 103584 0 0.0
.text 971452 971452 0 0.0
bl702l+mfd (read/write) 1191368 1191368 0 0.0
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 102524 102524 0 0.0
.text 983774 983774 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 797340 797340 0 0.0
(read/write) 177700 177700 0 0.0
.bss 99612 99612 0 0.0
.data 3604 3604 0 0.0
.rodata 85868 85868 0 0.0
.text 711208 711208 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813064 813064 0 0.0
(read/write) 188172 188172 0 0.0
.bss 110100 110100 0 0.0
.data 3596 3596 0 0.0
.rodata 79344 79344 0 0.0
.text 733456 733456 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802388 802388 0 0.0
(read/write) 182292 182292 0 0.0
.bss 104220 104220 0 0.0
.data 3596 3596 0 0.0
.rodata 106668 106668 0 0.0
.text 695456 695456 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755300 755300 0 0.0
(read/write) 176644 176644 0 0.0
.bss 98336 98336 0 0.0
.data 3588 3588 0 0.0
.rodata 81276 81276 0 0.0
.text 673760 673760 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740972 740972 0 0.0
(read/write) 176884 176884 0 0.0
.bss 98576 98576 0 0.0
.data 3588 3588 0 0.0
.rodata 77060 77060 0 0.0
.text 663648 663648 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606454 606454 0 0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 90206 90206 0 0.0
.text 514128 514128 0 0.0
lock CC3235SF_LAUNCHXL (read only) 651734 651734 0 0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 111086 111086 0 0.0
.text 538524 538524 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740499 740499 0 0.0
.app_xip_area 660445 660445 0 0.0
.bss 73652 73652 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 762975 762975 0 0.0
.app_xip_area 680289 680289 0 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 762975 762975 0 0.0
.app_xip_area 680289 680289 0 0.0
.bss 75516 75516 0 0.0
.data 1708 1708 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 712355 712355 0 0.0
.app_xip_area 637233 637233 0 0.0
.bss 68776 68776 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 678691 678691 0 0.0
.app_xip_area 602933 602933 0 0.0
.bss 69236 69236 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 700887 700887 0 0.0
.app_xip_area 622577 622577 0 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 700887 700887 0 0.0
.app_xip_area 622577 622577 0 0.0
.bss 71100 71100 0 0.0
.data 1748 1748 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 697051 697051 0 0.0
.app_xip_area 618277 618277 0 0.0
.bss 72284 72284 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 719319 719319 0 0.0
.app_xip_area 637993 637993 0 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 719319 719319 0 0.0
.app_xip_area 637993 637993 0 0.0
.bss 74148 74148 0 0.0
.data 1716 1716 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 659803 659803 0 0.0
.app_xip_area 587061 587061 0 0.0
.bss 66444 66444 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 682279 682279 0 0.0
.app_xip_area 606905 606905 0 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 682279 682279 0 0.0
.app_xip_area 606905 606905 0 0.0
.bss 68308 68308 0 0.0
.data 1604 1604 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1070772 1070772 0 0.0
.bss 180056 180056 0 0.0
.data 3448 3448 0 0.0
.text 887248 887248 0 0.0
lock-app BRD4338a (read/write) 962476 962476 0 0.0
.bss 213260 213260 0 0.0
.data 29448 29448 0 0.0
.text 700400 700400 0 0.0
window-app BRD4187C (read/write) 1135104 1135104 0 0.0
.bss 164584 164584 0 0.0
.data 3352 3352 0 0.0
.text 967148 967148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1210360 1210360 0 0.0
(read/write) 1752704 1752704 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 254768 254768 0 0.0
.flash.text 1210360 1210360 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1253367 1253367 0 0.0
(read/write) 537300 537300 0 0.0
.dram0.bss 79680 79680 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 286504 286504 0 0.0
.flash.text 1247203 1247203 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2713685 2713685 0 0.0
(read/write) 133328 133328 0 0.0
.bss 47880 47880 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 77144 77144 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 188336 188336 0 0.0
.text 2341141 2341141 0 0.0
all-clusters-app debug (read only) 6002929 6002929 0 0.0
(read/write) 486344 486344 0 0.0
.bss 136160 136160 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 338136 338136 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 355792 355792 0 0.0
.text 5204963 5204963 0 0.0
all-clusters-minimal-app debug (read only) 5289817 5289817 0 0.0
(read/write) 241720 241720 0 0.0
.bss 129024 129024 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 101112 101112 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 294506 294506 0 0.0
.text 4752547 4752547 0 0.0
bridge-app debug (read only) 4701873 4701873 0 0.0
(read/write) 221736 221736 0 0.0
.bss 119552 119552 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 89168 89168 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 234922 234922 0 0.0
.text 4240259 4240259 0 0.0
chip-tool debug (read only) 12200865 12200865 0 0.0
(read/write) 530400 530400 0 0.0
.bss 95128 95128 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 422904 422904 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 459801 459801 0 0.0
.text 11013699 11013699 0 0.0
chip-tool-ipv6only arm64 (read only) 11529628 11529628 0 0.0
(read/write) 597160 597160 0 0.0
.bss 104152 104152 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 463064 463064 0 0.0
.dynamic 528 528 0 0.0
.got 17320 17320 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 361340 361340 0 0.0
.text 10266472 10266472 0 0.0
fabric-admin debug (read only) 11933849 11933849 0 0.0
(read/write) 518440 518440 0 0.0
.bss 94488 94488 0 0.0
.data 4866 4866 0 0.0
.data.rel.ro 412088 412088 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 430809 430809 0 0.0
.text 10805475 10805475 0 0.0
fabric-bridge-app debug (read only) 4569345 4569345 0 0.0
(read/write) 213752 213752 0 0.0
.bss 115104 115104 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86896 86896 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 228010 228010 0 0.0
.text 4116963 4116963 0 0.0
lighting-app debug+rpc+ui (read only) 5615345 5615345 0 0.0
(read/write) 230920 230920 0 0.0
.bss 120496 120496 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 98000 98000 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 359156 359156 0 0.0
.text 5002275 5002275 0 0.0
lock-app debug (read only) 4757249 4757249 0 0.0
(read/write) 209120 209120 0 0.0
.bss 114792 114792 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 83416 83416 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 260778 260778 0 0.0
.text 4278419 4278419 0 0.0
ota-provider-app debug (read only) 4374169 4374169 0 0.0
(read/write) 197464 197464 0 0.0
.bss 114624 114624 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 72464 72464 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 212746 212746 0 0.0
.text 3962387 3962387 0 0.0
ota-requestor-app debug (read only) 4502953 4502953 0 0.0
(read/write) 201896 201896 0 0.0
.bss 115520 115520 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 75632 75632 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 218826 218826 0 0.0
.text 4080403 4080403 0 0.0
shell debug (read only) 2975985 2975985 0 0.0
(read/write) 158320 158320 0 0.0
.bss 60752 60752 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 90288 90288 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 191392 191392 0 0.0
.text 2602802 2602802 0 0.0
thermostat-no-ble arm64 (read only) 4491644 4491644 0 0.0
(read/write) 250520 250520 0 0.0
.bss 123144 123144 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 106768 106768 0 0.0
.dynamic 528 528 0 0.0
.got 9144 9144 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162516 162516 0 0.0
.text 3985720 3985720 0 0.0
tv-app debug (read only) 5831265 5831265 0 0.0
(read/write) 350008 350008 0 0.0
.bss 238640 238640 0 0.0
.data 6592 6592 0 0.0
.data.rel.ro 97480 97480 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 302282 302282 0 0.0
.text 5280787 5280787 0 0.0
tv-casting-app debug (read only) 10011881 10011881 0 0.0
(read/write) 349096 349096 0 0.0
.bss 156728 156728 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 182384 182384 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 389720 389720 0 0.0
.text 9134227 9134227 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535776 2535776 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1498460 1498460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058788 1058788 0 0.0
bss 139209 139209 0 0.0
rodata 102788 102788 0 0.0
text 769520 769520 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1235720 1235720 0 0.0
bss 137637 137637 0 0.0
rodata 152224 152224 0 0.0
text 795820 795820 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1006532 1006532 0 0.0
bss 138107 138107 0 0.0
rodata 90004 90004 0 0.0
text 731208 731208 0 0.0
nxp contact k32w0+release (read only) 575668 575668 0 0.0
(read/write) 83204 83204 0 0.0
.bss 67912 67912 0 0.0
.data 2200 2200 0 0.0
.text 575132 575132 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703892 703892 0 0.0
.bss 71272 71272 0 0.0
.data 2872 2872 0 0.0
.text 590368 590368 0 0.0
light k32w0+release (read only) 609560 609560 0 0.0
(read/write) 82688 82688 0 0.0
.bss 67368 67368 0 0.0
.data 2220 2220 0 0.0
.text 609024 609024 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795576 795576 0 0.0
.bss 80816 80816 0 0.0
.data 2080 2080 0 0.0
.text 673312 673312 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826128 826128 0 0.0
(read/write) 1824412 1824412 0 0.0
.bss 204460 204460 0 0.0
.data 2752 2752 0 0.0
.text 1608812 1608812 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829224 829224 0 0.0
(read/write) 1745900 1745900 0 0.0
.bss 201388 201388 0 0.0
.data 2728 2728 0 0.0
.text 1533396 1533396 0 0.0
light cy8ckit_062s2_43012 (read only) 835944 835944 0 0.0
(read/write) 1665532 1665532 0 0.0
.bss 194852 194852 0 0.0
.data 2544 2544 0 0.0
.text 1459748 1459748 0 0.0
lock cy8ckit_062s2_43012 (read only) 808880 808880 0 0.0
(read/write) 1694732 1694732 0 0.0
.bss 221932 221932 0 0.0
.data 2528 2528 0 0.0
.text 1461884 1461884 0 0.0
qpg lighting-app qpg6105+debug (read/write) 838532 838532 0 0.0
.bss 103780 103780 0 0.0
.data 864 864 0 0.0
.text 649920 649920 0 0.0
lock-app qpg6105+debug (read/write) 798380 798380 0 0.0
.bss 98444 98444 0 0.0
.data 876 876 0 0.0
.text 609772 609772 0 0.0
stm32 light STM32WB5MM-DK (read/write) 622570 622570 0 0.0
.bss 141060 141060 0 0.0
.data 672 672 0 0.0
.rodata 82036 82036 0 0.0
.text 389184 389184 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834642 834642 0 0.0
bss 49944 49944 0 0.0
text 624574 624574 0 0.0
all-clusters-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 840084 840084 0 0.0
bss 79088 79088 0 0.0
noinit 46096 46096 0 0.0
text 596936 596936 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1056692 1056692 0 0.0
bss 110132 110132 0 0.0
text 769300 769300 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 915056 915056 0 0.0
bss 92888 92888 0 0.0
text 656072 656072 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836494 836494 0 0.0
bss 49988 49988 0 0.0
text 626380 626380 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 947528 947528 0 0.0
bss 76580 76580 0 0.0
text 713260 713260 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 770076 770076 0 0.0
bss 75336 75336 0 0.0
noinit 46096 46096 0 0.0
text 555226 555226 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090224 1090224 0 0.0
bss 99980 99980 0 0.0
text 792656 792656 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911284 911284 0 0.0
bss 69268 69268 0 0.0
text 659424 659424 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933876 933876 0 0.0
bss 92620 92620 0 0.0
text 674954 674954 0 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831576 831576 0 0.0
bss 58232 58232 0 0.0
text 621012 621012 0 0.0
pump-controller-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 606960 606960 0 0.0
bss 44160 44160 0 0.0
noinit 32512 32512 0 0.0
text 450128 450128 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675304 675304 0 0.0
bss 71852 71852 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844122 844122 0 0.0
bss 51616 51616 0 0.0
text 632780 632780 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 859629 859629 0 0.0
bss 59804 59804 0 0.0
text 642490 642490 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825720 825720 0 0.0
bss 56492 56492 0 0.0
text 617838 617838 0 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835848 835848 0 0.0
bss 58448 58448 0 0.0
text 622782 622782 0 0.0

arkq
arkq approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@arkq arkq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be quoted somehow: https://datatracker.ietf.org/doc/html/rfc4122#section-3:

Each field is treated as an integer and has its value printed as a
zero-filled hexadecimal digit string with the most significant
digit first. The hexadecimal values "a" through "f" are output as
lower case characters and are case insensitive on input.

EDIT: UUID in the docstring on line 58 should also be converted to lowercase.

@arkq arkq mentioned this pull request Jun 3, 2024
Merged
@andy31415 andy31415 merged commit 00aa101 into project-chip:master Jun 3, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@harimau-qirex harimau-qirex harimau-qirex approved these changes

@tehampson tehampson tehampson approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@jlatusek jlatusek jlatusek approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
ble review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andy31415 @arkq @harimau-qirex @tehampson @yunhanw-google @jlatusek @andreilitvin