-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate exec link map files by default #33635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33635: Size comparison from b9eee28 to 5c0c4df Full report (40 builds for esp32, linux, mbed, nrfconnect, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 28, 2024 14:25
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 28, 2024 14:25
PR #33635: Size comparison from b9eee28 to e5ba1a4 Increases (4 builds for cc32xx, linux)
Decreases (3 builds for linux, mbed, stm32)
Full report (9 builds for cc32xx, linux, mbed, nrfconnect, stm32)
|
PR #33635: Size comparison from b9eee28 to d69b610 Increases (9 builds for cc32xx, esp32, linux, nxp, psoc6)
Decreases (27 builds for bl702, bl702l, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32)
Full report (44 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33635: Size comparison from 194d918 to cf5eeea Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #33635: Size comparison from 194d918 to f0909df Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
mspang
reviewed
May 29, 2024
andy31415
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Link map files can be really huge. The problem is with CI where the overall storage is capped to 14GB. Currently Tizen CI QEMU check is almost over the top and with changes in #33358 CI can no longer hold all the files.
Changes
chip_generate_link_map_file=true
togn gen
args, or by adding--enable-link-map-file
to./scripts/build/build_examples.py
Testing
Tested with
tizen-arm-tests-no-ble-no-thread
, and after this change the build directory is 6.7GB, where it was 9.8GB before.