-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] add dependencies for bulding Android App #3336
[build] add dependencies for bulding Android App #3336
Conversation
rsync \ | ||
swig \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are required when building the Android App by following the README doc, Please also see the document-update PR #3334.
# Download and install android command line tool (for installing `sdkmanager`) | ||
RUN set -x \ | ||
&& wget -O /tmp/android-tools.zip https://dl.google.com/android/repository/sdk-tools-linux-3859397.zip \ | ||
&& cd /opt/android/sdk \ | ||
&& unzip /tmp/android-tools.zip \ | ||
&& rm -f /tmp/android-tools.zip \ | ||
&& test -d /opt/android/sdk/tools \ | ||
&& : # last line | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need sdkmanager
to download Android SDKs and it comes with this Android SDK tool package.
e911353
to
dddd70d
Compare
@@ -1 +1 @@ | |||
0.4.12 | |||
0.4.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of changing this, please unlink the chip-build-android/version from chip-build/version and update only chip-build-android/version to 0.4.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwalker-apple Updated. But did you mean 0.4.13
? We are now in version 0.4.12
(and there are 0.4.12
TAG on docker hub).
@rwalker-apple We need |
looks like @mspang beat me to it |
Yeah, Thanks anyway! |
Problem
There are missing dependencies in the android build docker image for us to run
./gradlew build
to build the Android App.Summary of Changes
Add dependencies required to build the Android App from command line (with
./gradlew build
).Fixes #3335.