Refactored transport/raw/tests to more cleanly handle access to private members of TCPBase #33306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s where test needs access to private members and put those in a TestAccess class. Moved TCPBaseTestAccess into an H file so it can be used by other tests in the future.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33306: Size comparison from 062e063 to e6549ab Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33306: Size comparison from be19fc9 to 898d893 Full report (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
|
Damian-Nordic
approved these changes
May 6, 2024
…nto feature/unittest--transport-raw-tests_v3
…thub.com/feasel0/connectedhomeip into feature/unittest--transport-raw-tests_v3
|
PR #33306: Size comparison from d19798c to bacce91 Decreases (2 builds for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…nto feature/unittest--transport-raw-tests_v3
…m headers, C++ standard library headers, other libraries' headers, your project's headers"
|
PR #33306: Size comparison from 3c5b92c to d02d21c Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 6, 2024
pidarped
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestTCP requires access to private members of TCPBase. Previously this was done by friending TCPTest and then putting entire test functions into that class.
As suggested by #33269, I've isolated the operations that require private access and moved them to an accessor class TCPBaseTestAccess in a separate header file that may be used by any future test that also requires this access.
TCPBase now friends TCPBaseTestAccess instead of the less-clearly-named
chip::Transport::TCPTest, and thus many of the references to the nameTCPTestare now gone. Oncesrc/inet/tests/TestInetLayer.cpphas been refactored to use a new TestAccess class, the similarly namedchip::Inet::TCPTestcan be removed fromsrc/inet/TCPEndPoint.h, the last place that references that name.TestUDP.cpp was also refactored so as to match the way TestTCP.cpp defines its fixtures, since the two unit tests are very similar in structure.