Darwin: Address various MTRSetupPayload issues #33286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33286: Size comparison from fcfc9bc to cac7ccd Decreases (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
Full report (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
|
ksperling-apple
force-pushed
the
mtrsetuppayload
branch
from
cac7ccd
to
d6fe2cb
Compare
ksperling-apple
force-pushed
the
mtrsetuppayload
branch
from
d6fe2cb
to
4f1a51b
Compare
|
PR #33286: Size comparison from fcfc9bc to 4f1a51b Decreases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
ksperling-apple
force-pushed
the
mtrsetuppayload
branch
from
4f1a51b
to
acd0aec
Compare
|
PR #33286: Size comparison from fcfc9bc to acd0aec Increases (3 builds for bl702l, linux)
Decreases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
API: - Conform to NSCopying and implement isEqual / hash - Simplify a number of methods to not return NSError - Add initWithPayload: as a replacement for setupPayloadWithOnboardingPayload:error: - Add initWithQRCode: and initWithManualPairingCode: for cases where payload type is known. - Add vendorElements as a replacement for getAllOptionalVendorData: - Add vendorElementWithTag: - Add removeVendorElementWithTag: - Add addOrReplaceVendorElement: Behaviour fixes: - Allow QRCodes with unknown discovery methods to be parsed - Correctly generate a long manualEntryCode when a non-standard flow is indicated - Include vendor elements in qrCodeString - Preserve vendor elements in encodeWithCoder / initWithCoder Also simplify the implementation by acting as a direct wrapper of chip::SetupPayload. Implement parsing in MTRSetupPayload directly and implement the deprecated MTR*PayloadParser classes in terms of it, instead of the other way around.
ksperling-apple
force-pushed
the
mtrsetuppayload
branch
from
acd0aec
to
032e1f9
Compare
|
PR #33286: Size comparison from 062e063 to 032e1f9 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
ksperling-apple
force-pushed
the
mtrsetuppayload
branch
from
032e1f9
to
a3466cc
Compare
|
PR #33286: Size comparison from 062e063 to a3466cc Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
woody-apple
requested changes
May 8, 2024
|
Requesting changes, as we need to keep confirmed to ObjectiveC framework conventions. If we want to produce additional refined for swift things, those should be separate. We should not be mixing worlds. |
woody-apple
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API:
Behaviour fixes:
Also simplify the implementation by acting as a direct wrapper of chip::SetupPayload.
Implement parsing in MTRSetupPayload directly and implement the deprecated
MTR*PayloadParserclasses in terms of it, instead of the other way around.