-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux tv-casting-app v1.3 IdentificationDeclaration message #33283
Merged
sharadb-amazon
merged 7 commits into
project-chip:master
from
pgregorr-amazon:linux-identificationDeclaration-2024-04-29
May 7, 2024
Merged
Linux tv-casting-app v1.3 IdentificationDeclaration message #33283
sharadb-amazon
merged 7 commits into
project-chip:master
from
pgregorr-amazon:linux-identificationDeclaration-2024-04-29
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33283: Size comparison from ddc06d4 to e222838 Increases (4 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
sharadb-amazon
requested changes
May 3, 2024
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/MCCastingPlayer.mm
Outdated
Show resolved
Hide resolved
e222838
to
2f039ed
Compare
PR #33283: Size comparison from 98c10ee to e1d72de Increases (4 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
examples/tv-casting-app/tv-casting-common/core/IdentificationDeclarationOptions.h
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/IdentificationDeclarationOptions.h
Outdated
Show resolved
Hide resolved
PR #33283: Size comparison from 98c10ee to 908203d Increases above 0.2%:
Increases (20 builds for linux, nrfconnect, telink)
Decreases (6 builds for efr32, linux, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
sharadb-amazon
approved these changes
May 7, 2024
examples/tv-casting-app/tv-casting-common/core/CommissionerDeclarationHandler.h
Outdated
Show resolved
Hide resolved
src/protocols/user_directed_commissioning/UserDirectedCommissioning.h
Outdated
Show resolved
Hide resolved
PR #33283: Size comparison from 98c10ee to c965cde Increases (5 builds for cc32xx, mbed, nrfconnect)
Full report (7 builds for cc32xx, mbed, nrfconnect, stm32)
|
chrisdecenzo
approved these changes
May 7, 2024
hawk248
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Linux tv-casting-app example app, implemented new Matter v1.3 IdentificationDeclaration message parameters. Modified the IdentificationDeclaration message parameters sent to the tv-app commissioner (CastingPlayer) during User Directed Commissioning (UDC).
Change summary
Testing
Verified and tested locally with the Linux, Android and iOS tv-casting-app example mobile apps, and the Linux tv-app (CastingPlayer). With the Linux example app, when the discovered tv-app is selected (using “cast request x”), the tv-casting-app initiates User Directed Commissioning (UDC) by sending the first IdentificationDeclaration message to the tv-app with the CommissionerPasscode flag set to true. When the tv-app receives the IdentificationDeclaration message, it displays the Commissioner-Generated passcode field in the logs as expected.