Darwin: Add more tests and tidy up MTRSetupPayload #33234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename the tests to more conventional names.
bzbarsky-apple
approved these changes
Apr 29, 2024
ksperling-apple
force-pushed
the
mtrsetuppayload-test
branch
from
42d8bf1
to
f2ad566
Compare
pullapprove
bot
requested review from
andy31415,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mspang,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang,
yufengwangca and
yunhanw-google
|
Fast-tracking Darwin-only change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some regression tests and make the initialization test reliable.
Fix error return value on getAllOptionalVendorData.
Tidy up includes.