[ICD] Add counter invalidation events to the ICD Test Event trigger handler #33174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
lib
app
tests
support
icd
mkardous-silabs
force-pushed
the
feature/icd_counter_trigger
branch
from
5c68353 to
ba4fcc5
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
mkardous-silabs
force-pushed
the
feature/icd_counter_trigger
branch
from
63de4c9 to
f41634d
Compare
|
PR #33174: Size comparison from 2495011 to f41634d Increases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #33174: Size comparison from 2495011 to 25d5f52 Increases above 0.2%:
Increases (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
Decreases (12 builds for linux)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33174: Size comparison from 2495011 to 1a5ede8 Increases (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
Full report (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
|
bzbarsky-apple
approved these changes
Apr 26, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #33174: Size comparison from 2495011 to 1d70aaf Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (13 builds for linux, telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33174: Size comparison from 5ce992d to 30100ac Increases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
bzbarsky-apple
approved these changes
Apr 26, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #33174: Size comparison from 5ce992d to 2732c04 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
| namespace Protocols { | ||
| namespace SecureChannel { | ||
|
|
||
| CHIP_ERROR CheckInCounter::InvalidateHalfCheckInCouterValues() |
There was a problem hiding this comment.
"Couter" is a typo
| * | ||
| * @return CHIP_ERROR Any error returned by a write to persisted storage. | ||
| */ | ||
| CHIP_ERROR InvalidateHalfCheckInCouterValues(); |
There was a problem hiding this comment.
"Couter" is a typo
| @@ -666,6 +668,14 @@ CHIP_ERROR ICDManager::HandleEventTrigger(uint64_t eventTrigger) | |||
| case ICDTestEventTriggerEvent::kRemoveActiveModeReq: | |||
| SetKeepActiveModeRequirements(KeepActiveFlag::kTestEventTriggerActiveMode, false); | |||
| break; | |||
| #if CHIP_CONFIG_ENABLE_ICD_CIP | |||
There was a problem hiding this comment.
When is this not enabled?
There was a problem hiding this comment.
For SIT devices that still use the TestEventTrigger but might not have the Check-In Protocol support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of the PR is to add two new ICD test event trigger events that increase the ICDCounter value to enable client behavior testing. The two events are :
IMPORTANT : PR also modifies the PersistedCounter check when updating the counter value because it prevented the counter from using the last counter value (max counter size value - UINTXX_MAX) and would return an error anytime the counter is increased afterwards. - #33175
PR adds / changes :
Drive by changes :
Note to revewiers:
TestICDManager will be converted to gtest in a follow up since it is a pretty large test file
Tests