MinMDNS - do not ask for IP addresses for every SRV record that is seen #33095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
mspang
approved these changes
Apr 22, 2024
|
PR #33095: Size comparison from e48e04a to 339e17b Increases (30 builds for bl602, bl702, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (4 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tcarmelveilleux
approved these changes
Apr 22, 2024
|
PR #33095: Size comparison from e48e04a to 2cb52b5 Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (3 builds for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
arkq
approved these changes
Apr 23, 2024
tehampson
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM, Just one comment. The PR comment say that a "test" program was added. I don't understand. Can you give a few more details on how to compile the "test" program, and how to run the test you ran so that one could theoretically duplicate your PR validation?
bzbarsky-apple
approved these changes
Apr 23, 2024
Updated the summary to reference the PR for the test program and how I tested |
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Apr 23, 2024
…en (project-chip#33095) * Initial version of a test app - ability to just send a packet into the world * Update constants to match a real advertisement * Only resolve IP addresses if we are interested in this path * Fix up logic: this is per peer id * Remove unused include * Undo debug code * Undo extra header add * Add header back, but with full path * Fix up some more headers * Remove unhelpful comment * Move tester program out (will be part of another PR) --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Apr 23, 2024
…en (project-chip#33095) * Initial version of a test app - ability to just send a packet into the world * Update constants to match a real advertisement * Only resolve IP addresses if we are interested in this path * Fix up logic: this is per peer id * Remove unused include * Undo debug code * Undo extra header add * Add header back, but with full path * Fix up some more headers * Remove unhelpful comment * Move tester program out (will be part of another PR) --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
This was referenced Apr 23, 2024
andy31415
added a commit
that referenced
this pull request
Apr 23, 2024
…en (#33119) * MinMDNS - do not ask for IP addresses for every SRV record that is seen (#33095) * Initial version of a test app - ability to just send a packet into the world * Update constants to match a real advertisement * Only resolve IP addresses if we are interested in this path * Fix up logic: this is per peer id * Remove unused include * Undo debug code * Undo extra header add * Add header back, but with full path * Fix up some more headers * Remove unhelpful comment * Move tester program out (will be part of another PR) --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Fix for 1.3 compatibility * Undo submodule update --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
andy31415
added a commit
that referenced
this pull request
Apr 23, 2024
…en (#33118) * MinMDNS - do not ask for IP addresses for every SRV record that is seen (#33095) * Initial version of a test app - ability to just send a packet into the world * Update constants to match a real advertisement * Only resolve IP addresses if we are interested in this path * Fix up logic: this is per peer id * Remove unused include * Undo debug code * Undo extra header add * Add header back, but with full path * Fix up some more headers * Remove unhelpful comment * Move tester program out (will be part of another PR) --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Fix for 1.2 compatibility * Undo submodule update * Bump prompt-toolkit requirement to fix ptpython version update (#30987) * Remove include that is not valid for 1.2 --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various devices will report their SRV records during browse operations and at boot-up.
General matter nodes however are not interested in these devices unless actively browsing or if explicitly doing operational resolve. This saves the stack trying some A/AAAA queries when a SRV patcket without IP information is received (typically if IP data does not fit in one dnssd packet).
Changes
Tested
all-clusters-app./scripts/build/build_examples.py --target linux-x64-minmdns buildand run./out/linux-x64-minmdns/minimal-mdns-testerto send a SRV packet without IPQueryResponder.cppto updateQueryResponderBase::MarkAditionalto explicitly filter A/AAAA records to not be marked as report additional items, so that they are not included in replies by default as additional items.