-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrectly reported NoReponse when single batch command sent to … #32362
Merged
mergify
merged 5 commits into
project-chip:master
from
tehampson:fix-extendable-api-when-single-invoke-request-sent
Feb 29, 2024
Merged
Fix incorrectly reported NoReponse when single batch command sent to … #32362
mergify
merged 5 commits into
project-chip:master
from
tehampson:fix-extendable-api-when-single-invoke-request-sent
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmelveilleux
approved these changes
Feb 28, 2024
PR #32362: Size comparison from b951c6c to 455346b Increases (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg)
Decreases (1 build for linux)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
yunhanw-google
approved these changes
Feb 28, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
February 28, 2024 20:48
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
February 28, 2024 20:49
PR #32362: Size comparison from 1c2f889 to 6b7eeef Increases (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Feb 29, 2024
This was referenced Feb 29, 2024
Sarthak-Shaha
pushed a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Mar 5, 2024
project-chip#32362) * Fix incorrectly reported NoReponse when single batch command sent to legacy device * Add tests * Add more tests * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
project-chip#32362) * Fix incorrectly reported NoReponse when single batch command sent to legacy device * Add tests * Add more tests * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new CommandSender APIs is used to send a single invoke request where
CommandRef
was provided in the request to a legacy device, CommandSender would incorrectly call the NoResposeCallback.This occurs because legacy device is allowed to drop CommandRef (as it doesn't even know to look for CommandRef, nor does it know what it means).
Fix by assuming if getting a response to a single request, we assume the response matches the single pending tracked command.
fixes: #32360