-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Rename EMBER_XXX to MATTER_XXX #32078
Merged
mergify
merged 2 commits into
project-chip:master
from
jepenven-silabs:rename_EMBER_define_to_MATTER
Feb 13, 2024
Merged
[SDK] Rename EMBER_XXX to MATTER_XXX #32078
mergify
merged 2 commits into
project-chip:master
from
jepenven-silabs:rename_EMBER_define_to_MATTER
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32078: Size comparison from bf9c86a to aa75c23 Decreases (1 build for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32078: Size comparison from bf9c86a to 6f67f35 Increases above 0.2%:
Increases (19 builds for cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Feb 13, 2024
jmartinez-silabs
approved these changes
Feb 13, 2024
6f67f35
to
99cf3c9
Compare
99cf3c9
to
5e2b6ec
Compare
5e2b6ec
to
1f18189
Compare
PR #32078: Size comparison from e63e9df to 1f18189 Increases (2 builds for linux)
Decreases (56 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
* Rename EMBER_ to MATTER_ * Fix last comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember prefixes are legacy from the ember corporation that was acquired a while back by Silicon Labs.
This is PR 2 of 2 to replace the EMBER prefix in the Matter stack defines with matter related defines.
In this PR EMBER_ are replaces with MATTER_. This PR was done with a single find and replace on the work done in PR
#32054 #32055 #32056. Meaning that no reference to
EMBER_ZCL_STATUS
was renamed or removed in this PR.