-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Make Logging Filtering global #31944
Merged
andy31415
merged 1 commit into
project-chip:master
from
agners:improve-python-log-filtering
Feb 14, 2024
Merged
[Python] Make Logging Filtering global #31944
andy31415
merged 1 commit into
project-chip:master
from
agners:improve-python-log-filtering
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log filtering is a global affair, so move the filtering functions to a global context too. This allows to setup logging before creating any device controller. It aligns with how the SDK treats logging. Also enable log filtering for the Linux platform to make the functionality useful on Linux.
agners
force-pushed
the
improve-python-log-filtering
branch
2 times, most recently
from
February 5, 2024 22:55
790e847
to
135037a
Compare
agners
changed the title
Make Logging Filtering global
[Python] Make Logging Filtering global
Feb 5, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
February 5, 2024 22:55
pullapprove
bot
requested review from
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
February 5, 2024 22:55
PR #31944: Size comparison from 9efee65 to 135037a Increases above 0.2%:
Increases (13 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
requested changes
Feb 6, 2024
yunhanw-google
approved these changes
Feb 8, 2024
tehampson
approved these changes
Feb 13, 2024
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
Log filtering is a global affair, so move the filtering functions to a global context too. This allows to setup logging before creating any device controller. It aligns with how the SDK treats logging. Also enable log filtering for the Linux platform to make the functionality useful on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log filtering is a global affair, so move the filtering functions to a global context too. This allows to setup logging before creating any device controller. It aligns with how the SDK treats logging.
Also enable log filtering for the Linux platform to make the functionality useful on Linux.