Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the generated files for example lighting and lock apps to include server init callbacks. #3180

Conversation

bzbarsky-apple
Copy link
Contributor

This allows the app to implement
emberAfPluginOnOffClusterServerPostInitCallback to sync up the data
model state with the state of the actual device when the data model
initializes.

Problem

We're not enabling the on/off server init callback, which is the right place for apps to sync up data model state with the state of the world at app startup.

Summary of Changes

Change the generated files to enable the callback.

…ude server init callbacks.

This allows the app to implement
emberAfPluginOnOffClusterServerPostInitCallback to sync up the data
model state with the state of the actual device when the data model
initializes.
@github-actions
Copy link

github-actions bot commented Oct 9, 2020

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-lock.elf text 6 6
chip-lock.elf rodata 4 4
chip-lock.elf [LOAD #1 [RWX]] -6 -6
chip-lighting.elf text 6 6
chip-lighting.elf rodata 4 4
chip-lighting.elf [LOAD #1 [RWX]] -6 -6
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.strtab,0,121
.symtab,0,96
.debug_info,0,68
.debug_str,0,35
.debug_frame,0,16
text,6,6
rodata,4,4
[Unmapped],0,3
.debug_line,0,1
[LOAD #1 [RWX]],-6,-6

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.strtab,0,121
.symtab,0,96
.debug_info,0,41
.debug_str,0,35
[Unmapped],0,6
text,6,6
rodata,4,4
.debug_line,0,1
[LOAD #1 [RWX]],-6,-6


@BroderickCarlin BroderickCarlin merged commit 551796a into project-chip:master Oct 12, 2020
rwalker-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 12, 2020
…ude server init callbacks. (project-chip#3180)

This allows the app to implement
emberAfPluginOnOffClusterServerPostInitCallback to sync up the data
model state with the state of the actual device when the data model
initializes.
rwalker-apple pushed a commit that referenced this pull request Oct 12, 2020
* Use enum class for TLVElementType and TLVTagControl.

This makes it easy to give them as specific size spec, which will
prevent issues with people adding out-of-range values and simplify
-Wconversion work.

* Check if the result of EncodeCommand is successful before trying to send the command (#3151)

* Remove verbose code comments (#3187)

Some devices are configured to act as Thread router instead of
sleepy-end device. This PR removes these incorrect or verbose comments.

* Remove {#mainpage} from the main README.md file (#3190)

* Remove Makefiles introduced by #3099 (#3191)

* [nRF Connect] README updates on Docker for MacOS and NCS version (#3175)

* [nRF Connect] README updates on Docker for MacOS and NCS version

* Restyled by prettier-markdown

* Rephrase a sentence

Co-authored-by: Restyled.io <commits@restyled.io>

* Modify the generated files for example lighting and lock apps to include server init callbacks. (#3180)

This allows the app to implement
emberAfPluginOnOffClusterServerPostInitCallback to sync up the data
model state with the state of the actual device when the data model
initializes.

* Use pragma once in more places (#3182)

* Add a lot of pragma once changes. Now scripted!

* update pragma once in setup payload

* More pragma once

* Pragma once within platform and more

* pragma once in the crypto layer

* pragma once in examples

* Fix by restyle-diff

* [android] Use ATT Write Request instead of ATT Write Command (#3161)

Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
Co-authored-by: Yakun Xu <xyk@google.com>
Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Andrei Litvin <andrei@andy314.com>
Co-authored-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
@bzbarsky-apple bzbarsky-apple deleted the add-server-init-to-common-apps branch June 16, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants