-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android, Java, Kotlin] Divide IM API in java and kotlin. #31758
[Android, Java, Kotlin] Divide IM API in java and kotlin. #31758
Conversation
… divide_interaction_jni
PR #31758: Size comparison from 20c46c2 to c239aa0 Full report (3 builds for cc32xx, stm32)
|
PR #31758: Size comparison from 20c46c2 to c20c841 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
… divide_interaction_jni
PR #31758: Size comparison from 560a46b to 88510d8 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/controller/java/src/chip/devicecontroller/model/NodeState.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/NodeState.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/NodeState.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts on this large refactor.
particularly NodeState lifecycle can be fully managed by Java/Kotlin
and AttributeState/EventState Construction can be fully done in Java/Kotlin
and dedicated InteractionClient.JNI and Java and Kotlin module.
all are really beautiful.
Please help address the rest of comments so we can merged it.
… divide_interaction_jni
… divide_interaction_jni
PR #31758: Size comparison from 274719d to a9523c7 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Fix #30177
Divide Kotlin and Java JNI layer in IM API.