[EVSE] add evse cluster and examples energy management app #30793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed to use amperage_mA, energy_mWh - removed max on epoch_s - removed access for operate - removed side for events
…ogen, but still fails with some parts of regen_all
…ement-to-use-new-types-and-clean-up-other-comments-with-optional-xml' into 30727-add-evse-to-examplesenergy-management-app
…rgy Managament app.
|
PR #30793: Size comparison from 2a4a2ca to f27b036 Decreases (13 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg)
Full report (13 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg)
|
|
PR #30793: Size comparison from 2a4a2ca to 6763533 Increases (26 builds for esp32, linux, telink)
Decreases (46 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…test with chip-tool
|
PR #30793: Size comparison from 7f43a93 to 6ab439b Increases above 0.2%:
Increases (37 builds for bl602, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (38 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #30793: Size comparison from 7f43a93 to 34dd424 Increases above 0.2%:
Increases (37 builds for bl602, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (38 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…iagnostics.xml change to MS.
|
PR #30793: Size comparison from 221e466 to 23910e2 Increases above 0.2%:
Increases (30 builds for bl602, esp32, linux, nrfconnect, psoc6, telink)
Decreases (55 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jamesharrow
commented
Dec 15, 2023
examples/energy-management-app/energy-management-common/include/EnergyEvseDelegateImpl.h
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Dec 15, 2023
examples/energy-management-app/energy-management-common/include/EnergyEvseManager.h
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Dec 15, 2023
examples/energy-management-app/energy-management-common/include/EnergyManagementManager.h
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Dec 15, 2023
examples/energy-management-app/energy-management-common/src/EnergyEvseDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Dec 15, 2023
examples/energy-management-app/energy-management-common/src/EnergyEvseManager.cpp
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Dec 15, 2023
examples/energy-management-app/energy-management-common/src/EnergyManagementManager.cpp
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Dec 15, 2023
jamesharrow
commented
Dec 15, 2023
|
PR #30793: Size comparison from 0a5f3d3 to 7385acd Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 16, 2023
examples/energy-management-app/energy-management-common/energy-management-app.matter
Outdated
Show resolved
Hide resolved
examples/energy-management-app/energy-management-common/energy-management-app.matter
Show resolved
Hide resolved
|
PR #30793: Size comparison from 0a5f3d3 to 49f39b5 Increases (1 build for linux)
Decreases (4 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
dhrishi
approved these changes
Dec 18, 2023
|
Approving it as per the review from Sonali |
|
PR #30793: Size comparison from 7cbac91 to 2329d46 Increases (1 build for linux)
Decreases (4 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jamesharrow
deleted the
30727-add-evse-to-examplesenergy-management-app
branch
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
…hip#30793) * Fix project-chip#30665 (EVSE) - Changed to use amperage_mA, energy_mWh - removed max on epoch_s - removed access for operate - removed side for events * Fix project-chip#30665 updates to try to get further with ZAP and autogen, but still fails with some parts of regen_all * Added ember-compatibility-functions.cpp which was missing. * Made all types all lowercase to resolve regen_all issues. * Fixed lint issue (trailing whitespace). * Fixes project-chip#30727 - Added initial EVSE cluster and Example Energy Managament app. * Tidied up old comments. * Restyled by whitespace * Restyled by gn * Restyled by prettier-markdown * Added copy of files to all-clusters-app linux BUILD.gn and did basic test with chip-tool * Fixed lint error (Remove PRId64) * Fix for Documentation Build and publish checker. * Updated all-clusters-app.zap after merge and regen_all * Added Cluster to ESP32 CMakeLists.txt * Fixed ESP32 compile error caused by %d * Added missing source files to each build variant * Restyled by gn * Fixed incorrect uint64_t in EnableCharging/EnableDischarging command * Fixed more issues seen on different platforms * Removed unused mEndpointId * Add source files to shell standalone BUILD.gn, More %d fixes for different platforms * Restyled by gn * Removed unused mMinimumChargingCurrentLimitFromCommand * Removed yet more unused variables * Fixed missing semi-colon. How did the other compilers not pick this up? * Capitalise function names * PR comment - Moved PluginServerInitCallback to sdk. Capitalised more function names in energy-management-app. * Restyled by whitespace * Fixes project-chip#30805 Updated energy-evse-cluster.xml * Fixes project-chip#30805 zap_regen_all commit. * Made Fault Event allow a nullable SessionID * Updates based on review (use kMaximumChargeCurrent instead of duplicate #define). Add HwSetVehicleID implementation * Added RFID Event support. Removed more unnecessary chip:: * Added Feature flags, optional commands and optional attributes. * Made command handling conditional based on features * Added Feature support to all-clusters-app * Restyled by clang-format * Fix to Darwin compile error - not checking strcmp return * Attempt to fix Darwin errors (return after else) * Updated based on latest upstream master * Removed unnecessary mInstance and used 'this' instead. * Regen_all after merge to master. * Fix review comment. * Ensure Init() returns a failure if there is one. Aligned to mode-base-server.cpp * Backed out Read attr check based on features. * Fixed EnumerateAcceptedCommands to handle Loop::Break condition. * Had missed StartDiagnostic as an optional command in InvokeCommand * Removed extra chip:: in attr types. * Updated HwSetVehicleID to copy the value from callee * Fixed potential buffer overrun in HwSetVehicleID. * Fixed simple to address comments raised by Andrei in PR 30857 * Check Delegate is initialized before calling functions. * Ensured that mVehicleID free's any malloc'd CharSpan in destructor * Sync EnergyEvseDelegateImpl.cpp from Example Energy Management * Re-write of ApplicationInit to handle potential errors * Open and saved in ZAP, then regen_all * Updated Energy-management-app.zap / .matter after change to general-diagnostics.xml change to MS. * Fixed types to be signed=true * Fixed 31032 - revert removal of side="server". Also turned on Events. * PR comment fix - remove Localization Config and Time Format Localization cluster --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30727
Fixes #30665
Fixed #30805
This is an omnibus PR which should be reviewed after #30857
Adds EVSE SDK and all-clusters-app.
It includes the new Energy-Management-App example
NOTE: the Energy EVSE XML makes SessionID nullable and changes TargetTime (as per spec https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8631)