Move //gn/* to //* #3070
Merged
Move //gn/* to //* #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids needing to use the secondary_source path remapping which can cause confusion as the contents of //gn are all named without saying "//gn". By convention, the build system shared files are placed at //build and non-shares files are //build_overrides. This allows drop the CHIP build into other projects as a submodule, as long as they follow the same conventions.
mspang
force-pushed
the
for-chip/move-build-up
branch
from
8201edd
to
bfccca3
Compare
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
rwalker-apple and
saurabhst
bzbarsky-apple
approved these changes
Oct 6, 2020
andy31415
approved these changes
Oct 6, 2020
saurabhst
approved these changes
Oct 7, 2020
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Feb 24, 2021
This path changed way back in 55d6a5f ("Move //gn/* to //* (project-chip#3070)"). Remove the directory portion.
andy31415
pushed a commit
that referenced
this pull request
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To avoid clashing with automake's artifacts dir, certain common
directories were placed inside //gn. This required GN to look up all paths
twice, once at the normal location and once inside //gn.
By convention, the build system shared files are placed at //build and
non-shared files are //build_overrides. This allows dropping CHIP
into other projects as a submodule, as long as they follow the same
conventions.
Summary of Changes
Move //gn/build to //build now that automake is removed.