Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'cluster side' from matter IDL files #30605

Merged
merged 30 commits into from
Nov 28, 2023
Merged

Remove 'cluster side' from matter IDL files #30605

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3b84b62
Mass remove of ClusterSide
andreilitvin Nov 21, 2023
5ad6352
Start adding helper functions for cluster selection - some code still…
andreilitvin Nov 21, 2023
2244348
Fix PluginApplicationCallbacks because this was sensitive to client/s…
andreilitvin Nov 21, 2023
1ab6e44
Side is not a thing that backwards compatibility can test anymore
andreilitvin Nov 21, 2023
0af4838
Start fixing the IDL generator text
andreilitvin Nov 21, 2023
09fb9af
Generate all clusters in the same way
andreilitvin Nov 21, 2023
a978523
Zap regen
andreilitvin Nov 21, 2023
ebe1014
Add better differs in output assertions
andreilitvin Nov 21, 2023
5628b12
Fix some whitespacing - zap regen
andreilitvin Nov 21, 2023
5de46c2
Event better whitespacing - zap regen
andreilitvin Nov 21, 2023
089df0e
Fix what gets generated and regen
andreilitvin Nov 21, 2023
b5f8e83
Cluster doxygen seems to take effect now (I believe)
andreilitvin Nov 21, 2023
4182c48
Some unit test updates - manually validated
andreilitvin Nov 21, 2023
fd9b539
Update documentation
andreilitvin Nov 21, 2023
f90ad0f
Restyle
andreilitvin Nov 21, 2023
413e854
Merge branch 'master' into no_client_server_cluster
andreilitvin Nov 21, 2023
ef025f5
Fix lint
andreilitvin Nov 21, 2023
f0c8ce4
Fix linter logic
andreilitvin Nov 21, 2023
2754f3f
Skip metadata for compares, add logic to allow repeated cluster defin…
andreilitvin Nov 21, 2023
3802ed0
Restyle
andreilitvin Nov 21, 2023
0b14bd9
Add a typedef
andreilitvin Nov 21, 2023
dba6cee
Fix tests and conversion to list
andreilitvin Nov 21, 2023
e5ad825
Restyle
andreilitvin Nov 21, 2023
164f9a6
Merge branch 'master' into no_client_server_cluster
andreilitvin Nov 24, 2023
71659db
Fix tests
andreilitvin Nov 24, 2023
3ba35d1
Restyle
andreilitvin Nov 24, 2023
b9b5af8
update comment
andreilitvin Nov 24, 2023
0cfe4cd
Merge branch 'master' into no_client_server_cluster
andy31415 Nov 27, 2023
130a0a8
Merge branch 'master' into no_client_server_cluster
andy31415 Nov 28, 2023
470d4c3
Zap regen
andy31415 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Start fixing the IDL generator text
  • Loading branch information
@andreilitvin
andreilitvin committed Nov 21, 2023
commit 0af483816e5b60e61d9f9e6df124a0e39f1be70c
2 changes: 1 addition & 1 deletion scripts/py_matter_idl/matter_idl/generators/idl/MatterIdl.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
{% for cluster in idl.clusters %}
{% if cluster.description %}/** {{cluster.description}} */
{% endif %}
{{cluster.api_maturity | idltxt}}{{cluster.side | idltxt}} cluster {{cluster.name}} = {{cluster.code}} {
{{cluster.api_maturity | idltxt}}cluster {{cluster.name}} = {{cluster.code}} {
{%- for enum in cluster.enums %}

enum {{enum.name}} : {{ enum.base_type}} {
Expand Down