ESP32 example app with basic and temperature cluster #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
andy31415
reviewed
Oct 5, 2020
examples/temperature-measurement-app/esp32/main/DataModelHandler.cpp
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/DeviceCallbacks.cpp
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/gen/af-gen-event.h
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/gen/att-storage.h
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/gen/call-command-handler.c
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/gen/call-command-handler.c
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/gen/clusters-callback-stubs.c
Show resolved
Hide resolved
BroderickCarlin
approved these changes
Oct 5, 2020
rwalker-apple
approved these changes
Oct 5, 2020
|
Is the primary purpose of the app for rendezvous paring and secure session messaging or exposing the temperature sensor cluster? If the former, could we rename it so? |
kedars
approved these changes
Oct 6, 2020
|
The primary purpose is to measure the code/data size of a minimal CHIP app. That means it needs to support all the networky bits of CHIP, plus the required "utility" clusters, plus a small set (maybe just one, in this case) of "application" clusters for the actual app functionality. |
bzbarsky-apple
approved these changes
Oct 6, 2020
examples/temperature-measurement-app/esp32/main/gen/clusters-callback-stubs.c
Show resolved
Hide resolved
shana-apple
force-pushed
the
sazria/temperature-app
branch
from
c405d59
to
5ad8431
Compare
shana-apple
force-pushed
the
sazria/temperature-app
branch
from
5ad8431
to
131e713
Compare
added 2 commits
October 19, 2020 10:09
|
@andy31415 this is ready for your approval, copyright stuff is fixed |
mspang
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a esp32 app which supports basic and temperature sensor cluster. This app should be able to perform rendez vous paring and secure session messaging. Temperature measurement cluster was added from Simplicity studio.
Fixes #2979 #2980