Implement PDC support in Network Commissioning cluster #30511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #30511: Size comparison from d7c7f8e to b7fb256 Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 16, 2023
|
PR #30511: Size comparison from d7c7f8e to e4797b8 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for cc13x4_26x4, esp32, linux, nrfconnect, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- Tidy up EnumerateAcceptedCommands - Move constructors out of header - Simplify debug text logic - Simplify enumeration of Iterator - Use CHIP_ERROR_FORMAT for logging errors - Refer to Status type name consistently
and add the relevant APIs to NetworkCommissioning::WiFiDriver.
ksperling-apple
force-pushed
the
network-commissioning-pdc
branch
from
e4797b8
to
0f8a8d4
Compare
pullapprove
bot
requested review from
andy31415,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
kkasperczyk-no
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang,
yufengwangca and
yunhanw-google
jmartinez-silabs
approved these changes
Nov 17, 2023
|
PR #30511: Size comparison from e17a09c to 0f8a8d4 Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
| * @param clientIdentityNetworkIndex If present, the index of the existing network configuration of which the Client | ||
| * Identity is to be re-used. Otherwise a new Client Identity shall be generated. | ||
| * @param outStatus The application-level status code (Status::kSuccess on success). | ||
| * @param outDebugText A debug text buffer that may be populated by the driver when a Status is returned. |
There was a problem hiding this comment.
This method now no longer ever returns a Status. The comments need to be fixed.
ksperling-apple
added a commit
to ksperling-apple/connectedhomeip
that referenced
this pull request
Nov 17, 2023
ksperling-apple
added a commit
to ksperling-apple/connectedhomeip
that referenced
this pull request
Nov 17, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits are best viewed separately:
Small refactorings of network-commissioning.cpp
Implement PDC support in Network Commissioning cluster and add the relevant APIs to NetworkCommissioning::WiFiDriver.