-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional UTF-8 unit test corner cases. #30406
Merged
mergify
merged 3 commits into
project-chip:master
from
tcarmelveilleux:add-more-utf8-tests
Nov 10, 2023
Merged
Add additional UTF-8 unit test corner cases. #30406
mergify
merged 3 commits into
project-chip:master
from
tcarmelveilleux:add-more-utf8-tests
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tcarmelveilleux
commented
Nov 10, 2023
- Add more corner cases around overlong strings and UTF-16 surrogate pairs that cannot happen in UTF-8.
- Fixed suite name.
- Thankfully, all tests still pass :)
- Add more corner cases around overlong strings and UTF-16 surrogate pairs that cannot happen in UTF-8. - Fixed suite name. - Thankfully, all tests still pass :)
tcarmelveilleux
commented
Nov 10, 2023
ksperling-apple
approved these changes
Nov 10, 2023
pullapprove
bot
requested review from
andy31415,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
kpschoedel and
lazarkov
November 10, 2023 03:57
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mspang,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang,
yufengwangca and
yunhanw-google
November 10, 2023 03:57
PR #30406: Size comparison from 6d9cb39 to 24a5b52 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.