-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages Cluster XML #30254
Messages Cluster XML #30254
Conversation
PR #30254: Size comparison from 9b64072 to 57a7785 Full report (15 builds for cc13x4_26x4, cc32xx, k32w, mbed, qpg)
|
PR #30254: Size comparison from 99f61c2 to cde7313 Increases (2 builds for esp32)
Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, mbed, qpg)
|
@drempelg could you run zap-regen and fix builds? |
PR #30254: Size comparison from f50e12b to dd272e6 Full report (4 builds for cc32xx, qpg)
|
@andy31415 codegen has been run and committed :) |
PR #30254: Size comparison from f50e12b to bb27fe3 Increases above 0.2%:
Increases (18 builds for linux, nrfconnect, psoc6, telink)
Decreases (2 builds for linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30254: Size comparison from f50e12b to 089ea6c Increases above 0.2%:
Increases (18 builds for linux, nrfconnect, psoc6, telink)
Decreases (2 builds for linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note the CI failures. Some are probably because you do not have java
installed so the formatting on all the java bits gets messed up. But some of the other CI failures look real in various ways (failing lints, failing reads on all-clusters-app because of the broken implementation, etc).
In general, the right order of things is:
- Add XML.
- Add implementation which is not too broken.
- Enable implementation in test apps.
@@ -205,6 +206,7 @@ | |||
"UserActiveModeTriggerHint", | |||
"UserActiveModeTriggerInstruction" | |||
], | |||
"Messages": ["Messages"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be here. Why is it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
@@ -207,6 +208,7 @@ | |||
"UserActiveModeTriggerHint", | |||
"UserActiveModeTriggerInstruction" | |||
], | |||
"Messages": ["Messages"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be here.
@bzbarsky-apple Continued the development here: |
The development has been handled under PR |
Adding the XML for the new messages cluster