-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-CC-5.4: Remove read steps #29897
Merged
Merged
TC-CC-5.4: Remove read steps #29897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed at the MM, most clients don't use individual reads to verify attributes. The reads in the test do not test any real client behaviour and are not requird in the spec.
PR #29897: Size comparison from e0bdee7 to 07f6c17 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29897: Size comparison from e0bdee7 to 3e4abdc Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #29897: Size comparison from f754eab to fd273dd Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 23, 2023
andy31415
approved these changes
Oct 23, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* TC-CC-5.4: Rmove read steps As discussed at the MM, most clients don't use individual reads to verify attributes. The reads in the test do not test any real client behaviour and are not requird in the spec. * zap * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the MM, most clients don't use individual reads to verify attributes. The reads in the test do not test any real client behaviour and are not requird in the spec.
see https://github.com/CHIP-Specifications/chip-test-plans/pull/3560 for corresponding test plan change.