-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android]Fix dynamic cluster dispatcher in controller #29575
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/fix_dynamic_server
Oct 25, 2023
Merged
[Android]Fix dynamic cluster dispatcher in controller #29575
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/fix_dynamic_server
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
changed the title
Fix dynamic cluster dispatcher in controller
[Android]Fix dynamic cluster dispatcher in controller
Oct 5, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
October 5, 2023 05:53
PR #29575: Size comparison from f4c2094 to 8c659b4 Increases (5 builds for bl702l, efr32, linux)
Decreases (2 builds for cc13x4_26x4, cyw30739)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 24, 2023 07:45
8c659b4
to
354df34
Compare
PR #29575: Size comparison from 9ff8254 to 354df34 Full report (4 builds for mbed, nrfconnect)
|
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 24, 2023 16:20
354df34
to
1e7cf9d
Compare
PR #29575: Size comparison from 57f0a73 to 1e7cf9d Full report (6 builds for esp32, mbed, nrfconnect)
|
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 24, 2023 17:57
1e7cf9d
to
f319bbb
Compare
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 24, 2023 18:00
f319bbb
to
cf525cd
Compare
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 24, 2023 18:06
cf525cd
to
864bd2d
Compare
bzbarsky-apple
approved these changes
Oct 24, 2023
PR #29575: Size comparison from 7879111 to 864bd2d Increases (16 builds for bl702, efr32, k32w, linux, psoc6)
Decreases (10 builds for cc13x4_26x4, cyw30739, k32w, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 24, 2023 20:50
864bd2d
to
03d063c
Compare
PR #29575: Size comparison from cdd0aab to 03d063c Increases (16 builds for bl702, efr32, k32w, linux, psoc6)
Decreases (10 builds for cc13x4_26x4, cyw30739, k32w, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
Oct 25, 2023
yunhanw-google
force-pushed
the
feature/fix_dynamic_server
branch
from
October 25, 2023 00:35
03d063c
to
9c5c770
Compare
PR #29575: Size comparison from 3aac08f to 9c5c770 Increases (5 builds for bl702, k32w, psoc6)
Decreases (8 builds for cc13x4_26x4, cyw30739, k32w, psoc6)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29575: Size comparison from 3aac08f to edf565f Increases (16 builds for bl702, efr32, k32w, linux, psoc6)
Decreases (10 builds for cc13x4_26x4, cyw30739, k32w, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating with ota provider, we find CHIP_CONFIG_SKIP_APP_SPECIFIC_GENERATED_HEADER_INCLUDES cannot take effective for util/config.h when setting in src/app, we need to include common_flag in app/util/build.gn since this config.h is in util folder
We also need integrate src/controller:nodatamodel with OTAProvider in controller side as well, and disable the default IMClusterCommandHandler in data model template.
We still need chip data model since jni generated IM Cluster API still needs ChipCluster.h at this moment, now we just disable default server dispatcher and storage and util when using dynamic cluster dispatcher. Further we disable the data model codegen for java matter controller example app since it don't need chip data model.
Enable dynamic cluster dispatcher in android controller.