-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pw_unit_test support to build configuration #29479
Conversation
PR #29479: Size comparison from ea20416 to 53d6ceb Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29479: Size comparison from aedf2d5 to 97dca79 Decreases (1 build for bl702l)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for breaking this up into smaller pieces!
* Rename old chip_test_suite template to chip_test_suite_using_nltest It will be removed in the future, when it's no longer needed. * Make new chip_test_suite template, using pw_test instead of chip_test * Rename a few GN targets to be consistent with pigweed Make them end with `.lib` or `.run` instead of `_lib` or `_run`.
PR #29479: Size comparison from 433e676 to e449e2a Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29479: Size comparison from a40b53c to bb649f1 Decreases (1 build for bl702)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval assumes adding the TODO with issue tracker. Just allowing this to go through without the need for me to revisit
* Add pw_unit_test support to GN * Rename old chip_test_suite template to chip_test_suite_using_nltest It will be removed in the future, when it's no longer needed. * Make new chip_test_suite template, using pw_test instead of chip_test * Rename a few GN targets to be consistent with pigweed Make them end with `.lib` or `.run` instead of `_lib` or `_run`. * Reordered declarations in .gn for readability * Update .gn
This is the first of a series of PRs, aiming to replace nlunit-test with pw_unit_test (#29342, but split into smaller chunks).
Changes
pw_unit_test
added to./.gn
./build/chip/chip_test_suite.gni
changed, so it invokespw_test
build/chip/chip_test.gni
andbuild/chip/chip_test_group.gni
, to keep target naming consistent**/BUILD.gn