Commits on Sep 21, 2023

1. Fix chip-tool storage ifdefs to make more sense. …

   A few fixes here:
   
   1) CONFIG_USE_LOCAL_STORAGE was being defined to 0 when config_use_local_storage
      was false, but the tests for it use #ifdef, so setting
      config_use_local_storage to false did not work right.
   2) Commands.cpp was using config options from CHIPDeviceConfig.h without
      explicitly including it.  It happened to be pulled in by
      KeyValueStoreManager.h, but better to not depend on it.
   3) The UseStorageDirectory bits dependency on CHIP_DISABLE_PLATFORM_KVS was set
      up such that if it was true we ended up with an unused
      PersistedStorage::KeyValueStoreMgrImpl() return value.  This got optimized
      out in optimized builds, so things worked, but in debug builds we would get
      link errors.
   4) Several Darwin CI jobs that were trying to build the Debug configuraion
      actually built the Release one, because they did not specify a configuration
      and that defaults to Release.
   5) Remove the unnecessary CHIP_DISABLE_PLATFORM_KVS bits from the Xcode project.

   

   bzbarsky-apple committed Sep 21, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for d38491f
   • Browse repository at this point

   Copy the full SHA

   d38491f View commit details

   Browse the repository at this point in the history