-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CONFIG_TLV_TRUNCATE. #29233
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-CONFIG_TLV_TRUNCATE
Sep 14, 2023
Merged
Remove CONFIG_TLV_TRUNCATE. #29233
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-CONFIG_TLV_TRUNCATE
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used right now, and it silently truncates the data being encoded, so should not be used. Fixes project-chip#29218
c50610f
to
e0543a6
Compare
PR #29233: Size comparison from 1d6ba7f to e0543a6 Decreases (8 builds for bl602, cc32xx, efr32, psoc6, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
approved these changes
Sep 13, 2023
Damian-Nordic
approved these changes
Sep 14, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
It's not used right now, and it silently truncates the data being encoded, so should not be used. Fixes project-chip#29218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used right now, and it silently truncates the data being encoded, so should not be used.
Fixes #29218