Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect preprocessor usage of LwIP PBUF_POOL #29232

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix incorrect preprocessor usage of LwIP PBUF_POOL #29232

merged 1 commit into from
Sep 13, 2023

Conversation

kpschoedel
Copy link
Contributor

Configuration allowed specifying an LwIP pbuf_type value for System::PacketBuffer allocations, and code tested this configuration in preprocessor conditions; however, the LwIP names are enum constants, not preprocessor defintions.

This change replaces the configuration macro with a new one selecting between PBUF_POOL and PBUF_RAM. (From PR#14257 that introduced the configuration, it does not appear that other options were ever used.)

Fixes #29208

@kpschoedel
Fix incorrect preprocessor usage of LwIP PBUF_POOL
8ce1689 
Configuration allowed specifying an LwIP `pbuf_type` value for
`System::PacketBuffer` allocations, and code tested this configuration
in preprocessor conditions; however, the LwIP names are enum constants,
not preprocessor defintions.

This change replaces the configuration macro with a new one selecting
between `PBUF_POOL` and `PBUF_RAM`. (From PR#14257 that introduced the
configuration, it does not appear that other options were ever used.)

Fixes project-chip#29208
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited
Loading

PR #29232: Size comparison from 1d6ba7f to 8ce1689

Decreases (3 builds for bl702, efr32, telink)
platform target config section 1d6ba7f 8ce16899 change % change
bl702 lighting-app bl702 (read/write) 1170131 1170127 -4 -0.0
.text 957170 957168 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1080912 1080904 -8 -0.0
.text 891488 891480 -8 -0.0
telink pump-controller-app tlsr9518adk80d (read/write) 872124 872116 -8 -0.0
text 586794 586792 -2 -0.0
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 1d6ba7f 8ce16899 change % change
bl602 lighting-app bl602 (read/write) 1368226 1368226 0 0.0
.bss 73478 73478 0 0.0
.data 9600 9600 0 0.0
.text 1061180 1061180 0 0.0
bl602+rpc (read/write) 1415366 1415366 0 0.0
.bss 81518 81518 0 0.0
.data 9952 9952 0 0.0
.text 1092858 1092858 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1170131 1170127 -4 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41301 41301 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 3584 3584 0 0.0
.debug_abbrev 1579611 1579611 0 0.0
.debug_aranges 138528 138528 0 0.0
.debug_frame 509072 509072 0 0.0
.debug_info 42356561 42356561 0 0.0
.debug_line 5472401 5472401 0 0.0
.debug_loc 3529647 3529647 0 0.0
.debug_ranges 381880 381880 0 0.0
.debug_str 3969854 3969854 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107104 107104 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 595756 595756 0 0.0
.symtab 176768 176768 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
957170 957168 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1267203 1267203 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1756425 1756425 0 0.0
.debug_aranges 147120 147120 0 0.0
.debug_frame 538156 538156 0 0.0
.debug_info 47266004 47266004 0 0.0
.debug_line 5880140 5880140 0 0.0
.debug_loc 3734688 3734688 0 0.0
.debug_ranges 407720 407720 0 0.0
.debug_str 4390619 4390619 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121976 121976 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 659917 659917 0 0.0
.symtab 195952 195952 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029876 1029876 0 0.0
bl706-eth (read/write) 1017072 1017072 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 25586 25586 0 0.0
.bss_psram 94447 94447 0 0.0
.comment 48 48 0 0.0
.data 3304 3304 0 0.0
.debug_abbrev 1117928 1117928 0 0.0
.debug_aranges 114712 114712 0 0.0
.debug_frame 425860 425860 0 0.0
.debug_info 23356026 23356026 0 0.0
.debug_line 4419197 4419197 0 0.0
.debug_loc 3029554 3029554 0 0.0
.debug_ranges 318736 318736 0 0.0
.debug_str 3541953 3541953 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 97300 97300 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 462007 462007 0 0.0
.symtab 138976 138976 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
776028 776028 0 0.0
bl706-wifi (read/write) 1089287 1089287 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 9981 9981 0 0.0
.bss_psram 95183 95183 0 0.0
.comment 48 48 0 0.0
.data 3624 3624 0 0.0
.debug_abbrev 1210745 1210745 0 0.0
.debug_aranges 118976 118976 0 0.0
.debug_frame 441312 441312 0 0.0
.debug_info 24521777 24521777 0 0.0
.debug_line 4640531 4640531 0 0.0
.debug_loc 3113640 3113640 0 0.0
.debug_ranges 327632 327632 0 0.0
.debug_str 3603354 3603354 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109576 109576 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 498772 498772 0 0.0
.symtab 151488 151488 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3402 3402 0 0.0
.text 0 0 0 0.0
849778 849778 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1155316 1155316 0 0.0
.boot2 292 292 0 0.0
.bss 16004 16004 0 0.0
.bss_psram 77648 77648 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1581979 1581979 0 0.0
.debug_aranges 133048 133048 0 0.0
.debug_frame 488788 488788 0 0.0
.debug_info 42363366 42363366 0 0.0
.debug_line 5388653 5388653 0 0.0
.debug_loc 3465427 3465427 0 0.0
.debug_ranges 387200 387200 0 0.0
.debug_str 3982301 3982301 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100968 100968 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 595950 595950 0 0.0
.symtab 176304 176304 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
945624 945624 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 737747 737747 0 0.0
(read/write) 166800 166800 0 0.0
.bss 89212 89212 0 0.0
.data 3424 3424 0 0.0
.rodata 84583 84583 0 0.0
.text 652776 652776 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757539 757539 0 0.0
(read/write) 177056 177056 0 0.0
.bss 99436 99436 0 0.0
.data 3440 3440 0 0.0
.rodata 80015 80015 0 0.0
.text 677136 677136 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 745451 745451 0 0.0
(read/write) 171528 171528 0 0.0
.bss 93908 93908 0 0.0
.data 3440 3440 0 0.0
.rodata 106263 106263 0 0.0
.text 638796 638796 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 695883 695883 0 0.0
(read/write) 165900 165900 0 0.0
.bss 88080 88080 0 0.0
.data 3412 3412 0 0.0
.rodata 80423 80423 0 0.0
.text 615072 615072 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681475 681475 0 0.0
(read/write) 166032 166032 0 0.0
.bss 88224 88224 0 0.0
.data 3408 3408 0 0.0
.rodata 76263 76263 0 0.0
.text 604824 604824 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 619066 619066 0 0.0
(read/write) 207256 207256 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200696 200696 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 969967 969967 0 0.0
.debug_aranges 107416 107416 0 0.0
.debug_frame 363180 363180 0 0.0
.debug_info 21321808 21321808 0 0.0
.debug_line 2806368 2806368 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1578162 1578162 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 99388 99388 0 0.0
.debug_str 3385845 3385845 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106506 106506 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 510328 510328 0 0.0
.symtab 297104 297104 0 0.0
.text 510440 510440 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 554775 554775 0 0.0
.app_xip_area 445657 445657 0 0.0
.bss 64088 64088 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539583 539583 0 0.0
.app_xip_area 425665 425665 0 0.0
.bss 68856 68856 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574935 574935 0 0.0
.app_xip_area 467153 467153 0 0.0
.bss 62824 62824 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558695 558695 0 0.0
.app_xip_area 447705 447705 0 0.0
.bss 65936 65936 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1008880 1008880 0 0.0
.bss 172268 172268 0 0.0
.data 2672 2672 0 0.0
.text 833920 833920 0 0.0
BRD4187C (read/write) 1080912 1080904 -8 -0.0
.bss 186144 186144 0 0.0
.data 3260 3260 0 0.0
.text 891488 891480 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1104276 1104276 0 0.0
.bss 186956 186956 0 0.0
.data 2684 2684 0 0.0
.text 914616 914616 0 0.0
window-app BRD4187C (read/write) 1128160 1128160 0 0.0
.bss 168768 168768 0 0.0
.data 3132 3132 0 0.0
.text 956240 956240 0 0.0
esp32 all-clusters-app c3devkit (read only) 1176508 1176508 0 0.0
(read/write) 1704116 1704116 0 0.0
.dram0.bss 79192 79192 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 268920 268920 0 0.0
.flash.text 1176508 1176508 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1217311 1217311 0 0.0
(read/write) 553570 553570 0 0.0
.dram0.bss 85800 85800 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 300116 300116 0 0.0
.flash.text 1211927 1211927 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 590108 590108 0 0.0
(read/write) 87920 87920 0 0.0
.bss 71168 71168 0 0.0
.data 2128 2128 0 0.0
.text 589572 589572 0 0.0
light k32w0+release (read only) 589916 589916 0 0.0
(read/write) 87596 87596 0 0.0
.bss 70856 70856 0 0.0
.data 2116 2116 0 0.0
.text 589380 589380 0 0.0
lock k32w0+release (read only) 561268 561268 0 0.0
(read/write) 85372 85372 0 0.0
.bss 68688 68688 0 0.0
.data 2060 2060 0 0.0
.text 560732 560732 0 0.0
linux all-clusters-app debug (read only) 5656569 5656569 0 0.0
(read/write) 421064 421064 0 0.0
.bss 130560 130560 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 279096 279096 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 339572 339572 0 0.0
.text 4935027 4935027 0 0.0
all-clusters-minimal-app debug (read only) 4929593 4929593 0 0.0
(read/write) 232608 232608 0 0.0
.bss 126496 126496 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 95120 95120 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272712 272712 0 0.0
.text 4425891 4425891 0 0.0
bridge-app debug (read only) 2772777 2772777 0 0.0
(read/write) 133136 133136 0 0.0
.bss 51768 51768 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71440 71440 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214504 214504 0 0.0
.text 2380627 2380627 0 0.0
chip-tool debug (read only) 10347401 10347401 0 0.0
(read/write) 442968 442968 0 0.0
.bss 93720 93720 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 336912 336912 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 389009 389009 0 0.0
.text 9361395 9361395 0 0.0
chip-tool-ipv6only arm64 (read only) 10186428 10186428 0 0.0
(read/write) 505384 505384 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 374272 374272 0 0.0
.dynamic 512 512 0 0.0
.got 18208 18208 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316344 316344 0 0.0
.text 9104520 9104520 0 0.0
lighting-app debug+rpc+ui (read only) 5252857 5252857 0 0.0
(read/write) 222760 222760 0 0.0
.bss 118192 118192 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92472 92472 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336948 336948 0 0.0
.text 4673235 4673235 0 0.0
lock-app debug (read only) 4479169 4479169 0 0.0
(read/write) 203096 203096 0 0.0
.bss 113456 113456 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 79080 79080 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248456 248456 0 0.0
.text 4021219 4021219 0 0.0
ota-provider-app debug (read only) 4130609 4130609 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113600 113600 0 0.0
.data 4032 4032 0 0.0
.data.rel.ro 68480 68480 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201128 201128 0 0.0
.text 3739043 3739043 0 0.0
ota-requestor-app debug (read only) 4224089 4224089 0 0.0
(read/write) 196344 196344 0 0.0
.bss 114656 114656 0 0.0
.data 4272 4272 0 0.0
.data.rel.ro 71480 71480 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204456 204456 0 0.0
.text 3824867 3824867 0 0.0
shell debug (read only) 3056769 3056769 0 0.0
(read/write) 153776 153776 0 0.0
.bss 60968 60968 0 0.0
.data 784 784 0 0.0
.data.rel.ro 86088 86088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 214738 214738 0 0.0
.text 2667298 2667298 0 0.0
thermostat-no-ble arm64 (read only) 4358268 4358268 0 0.0
(read/write) 241896 241896 0 0.0
.bss 122200 122200 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 100512 100512 0 0.0
.dynamic 512 512 0 0.0
.got 11824 11824 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161236 161236 0 0.0
.text 3862968 3862968 0 0.0
tv-app debug (read only) 5321409 5321409 0 0.0
(read/write) 350824 350824 0 0.0
.bss 242016 242016 0 0.0
.data 5136 5136 0 0.0
.data.rel.ro 96256 96256 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272920 272920 0 0.0
.text 4804435 4804435 0 0.0
tv-casting-app debug (read only) 8293777 8293777 0 0.0
(read/write) 211648 211648 0 0.0
.bss 54720 54720 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147576 147576 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 338524 338524 0 0.0
.text 7553811 7553811 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523336 2523336 0 0.0
.bss 219416 219416 0 0.0
.data 5128 5128 0 0.0
.text 1486020 1486020 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1242996 1242996 0 0.0
bss 155570 155570 0 0.0
rodata 143192 143192 0 0.0
text 865188 865188 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1361228 1361228 0 0.0
bss 141036 141036 0 0.0
rodata 137036 137036 0 0.0
text 792440 792440 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165268 1165268 0 0.0
bss 154968 154968 0 0.0
rodata 113920 113920 0 0.0
text 817436 817436 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837048 837048 0 0.0
(read/write) 1798076 1798076 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193740 193740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1428950 1428950 0 0.0
.debug_aranges 146128 146128 0 0.0
.debug_frame 486044 486044 0 0.0
.debug_info 33777831 33777831 0 0.0
.debug_line 4260170 4260170 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2319331 2319331 0 0.0
.debug_rnglists 145112 145112 0 0.0
.debug_str 4556183 4556183 0 0.0
.heap 837048 837048 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 863458 863458 0 0.0
.symtab 519440 519440 0 0.0
.text 0 0 0 0.0
1593396 1593396 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839808 839808 0 0.0
(read/write) 1685284 1685284 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191060 191060 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1294179 1294179 0 0.0
.debug_aranges 135848 135848 0 0.0
.debug_frame 457128 457128 0 0.0
.debug_info 29396285 29396285 0 0.0
.debug_line 3961672 3961672 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2134583 2134583 0 0.0
.debug_rnglists 134569 134569 0 0.0
.debug_str 3941395 3941395 0 0.0
.heap 839808 839808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 733548 733548 0 0.0
.symtab 472720 472720 0 0.0
.text 1483364 1483364 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846136 846136 0 0.0
(read/write) 1611012 1611012 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184844 184844 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1134002 1134002 0 0.0
.debug_aranges 125944 125944 0 0.0
.debug_frame 420172 420172 0 0.0
.debug_info 24439169 24439169 0 0.0
.debug_line 3525819 3525819 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1971366 1971366 0 0.0
.debug_rnglists 124266 124266 0 0.0
.debug_str 3748648 3748648 0 0.0
.heap 846136 846136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 648898 648898 0 0.0
.symtab 435008 435008 0 0.0
.text 1415420 1415420 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818880 818880 0 0.0
(read/write) 1642364 1642364 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212092 212092 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1124681 1124681 0 0.0
.debug_aranges 124600 124600 0 0.0
.debug_frame 415268 415268 0 0.0
.debug_info 24236226 24236226 0 0.0
.debug_line 3475314 3475314 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1946653 1946653 0 0.0
.debug_rnglists 122222 122222 0 0.0
.debug_str 3710735 3710735 0 0.0
.heap 818880 818880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 622023 622023 0 0.0
.symtab 426224 426224 0 0.0
.text 1419516 1419516 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178036 1178036 0 0.0
.bss 101024 101024 0 0.0
.data 744 744 0 0.0
.text 624880 624880 0 0.0
lock-app qpg6105+debug (read/write) 1134268 1134268 0 0.0
.bss 95728 95728 0 0.0
.data 748 748 0 0.0
.text 581108 581108 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1102532 1102532 0 0.0
bss 112384 112384 0 0.0
text 755150 755150 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1043036 1043036 0 0.0
bss 110164 110164 0 0.0
text 709116 709116 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948928 948928 0 0.0
bss 113748 113748 0 0.0
text 648344 648344 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 931988 931988 0 0.0
bss 103372 103372 0 0.0
text 620842 620842 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 925896 925896 0 0.0
bss 103616 103616 0 0.0
text 632414 632414 0 0.0
lighting-app-rpc-shell-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1001468 1001468 0 0.0
bss 115980 115980 0 0.0
text 697288 697288 0 0.0
tlsr9528a (read only) 4 4 0 0.0
(read/write) 1053824 1053824 0 0.0
bss 116584 116584 0 0.0
text 727282 727282 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 990068 990068 0 0.0
bss 104092 104092 0 0.0
text 651988 651988 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 903624 903624 0 0.0
bss 104108 104108 0 0.0
text 613768 613768 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 937428 937428 0 0.0
bss 103504 103504 0 0.0
text 626488 626488 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 872124 872116 -8 -0.0
bss 102708 102708 0 0.0
text 586794 586792 -2 -0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 748892 748892 0 0.0
bss 101572 101572 0 0.0
text 479414 479414 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 935720 935720 0 0.0
bss 103484 103484 0 0.0
text 625364 625364 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 920724 920724 0 0.0
bss 103212 103212 0 0.0
text 612536 612536 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 893548 893548 0 0.0
bss 103000 103000 0 0.0
text 602504 602504 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 889180 889180 0 0.0
bss 103324 103324 0 0.0
text 597834 597834 0 0.0

@mergify mergify bot merged commit ba85422 into project-chip:master Sep 13, 2023
@wy-hh wy-hh mentioned this pull request Sep 15, 2023
Closed
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@kpschoedel @HunsupJung
Fix incorrect preprocessor usage of LwIP PBUF_POOL (project-chip#29232)
61e96c4 
Configuration allowed specifying an LwIP `pbuf_type` value for
`System::PacketBuffer` allocations, and code tested this configuration
in preprocessor conditions; however, the LwIP names are enum constants,
not preprocessor defintions.

This change replaces the configuration macro with a new one selecting
between `PBUF_POOL` and `PBUF_RAM`. (From PR#14257 that introduced the
configuration, it does not appear that other options were ever used.)

Fixes project-chip#29208
@kpschoedel kpschoedel deleted the x29208 branch June 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecille cecille cecille approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [LwIP] Incorrect preprocessor usage of PBUF_POOL
4 participants
@kpschoedel @CLAassistant @cecille @bzbarsky-apple